Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_cli package #217

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add aws_cli package #217

merged 1 commit into from
Jan 29, 2025

Conversation

kylewlacy
Copy link
Member

This PR adds a new package for the AWS CLI: the Amazon Web Services Command Line Interface.

This one ended up being trickier than expected, for 3 reasons:

  1. It (currently) requires Python 3.12. I updated python to support both v3.12 and v3.13 in Update Python to support both v3.12 and v3.13 builds #216
  2. It builds a native dependency, and requires libffi. I added a new libffi package and linked it to Python in Add libffi package #215
  3. It has requirements.txt files that include hashes, but there are conflicting requirements around the packaging dependency (this only applies to the requirements-*-lock.txt files I believe, the standard requirements.txt file shouldn't have this problem but also doesn't have hashes). I solved this with a small patch file to resolve packaging to v24.2, which was the latest version used across all the files.

The actual packaging code was based heavily on the asciinema package. It'd be nice to write a general pythonInstall() function or something, but at least asciinema and aws_cli are different enough that I don't feel that it'd be easy to generalize them. My gut instinct is it'd be better to support a newer package manager first, such as uv.

@kylewlacy kylewlacy enabled auto-merge (squash) January 29, 2025 05:19
@kylewlacy kylewlacy merged commit cbd5963 into main Jan 29, 2025
3 checks passed
@kylewlacy kylewlacy deleted the add-aws-cli-package branch January 29, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant