Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): fix change locale from navigate #669

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

aralroca
Copy link
Collaborator

@aralroca aralroca commented Dec 7, 2024

Fixes #665

@aralroca aralroca self-assigned this Dec 7, 2024
@@ -27,16 +27,6 @@ describe('utils', () => {
expect(locale).toBe('ru');
});

it('should return req.i18n.locale when exist', () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was wrong

Copy link

pkg-pr-new bot commented Dec 7, 2024

Open in Stackblitz

brisa-adapter-vercel

npm i https://pkg.pr.new/brisa-build/brisa/brisa-adapter-vercel@669

brisa

npm i https://pkg.pr.new/brisa-build/brisa@669

brisa-tailwindcss

npm i https://pkg.pr.new/brisa-build/brisa/brisa-tailwindcss@669

brisa-pandacss

npm i https://pkg.pr.new/brisa-build/brisa/brisa-pandacss@669

create-brisa

npm i https://pkg.pr.new/brisa-build/brisa/create-brisa@669

www

npm i https://pkg.pr.new/brisa-build/brisa/www@669

commit: f7b9075

@aralroca aralroca merged commit a2dfd20 into canary Dec 7, 2024
5 of 8 checks passed
@aralroca aralroca deleted the aralroca/fix-i18n-change-locale branch December 7, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change language is currently not possible by using navigate.
1 participant