update code

pkg/utils/informer/informermanager.go

@@ -75,7 +75,6 @@ func NewInformerManager(client dynamic.Interface, scheme *runtime.Scheme, defaul
 	cfg := config.GetConfigOrDie()
 	c, err := Cache.New(cfg, Cache.Options{Scheme: scheme, SyncPeriod: &defaultResync})
 	if err != nil {
-		//handle error
 		klog.V(2).ErrorS(err, "Failed to create informer cache")
 	}
 	return &informerManagerImpl{
@@ -127,18 +126,13 @@ func (s *informerManagerImpl) AddDynamicResources(dynResources []APIResourceMeta
 	addInformerFunc := func(newRes APIResourceMeta) {
 		_, exist := s.apiResources[newRes.GroupVersionKind]
 		if !exist {
-			c, err := Cache.New(config.GetConfigOrDie(), Cache.Options{Scheme: s.scheme})
-			if err != nil {
-				//handle error
-				klog.ErrorS(err, "Failed to create informer cache")
-			}
-			s.cache = c
+			// TODO: how to add GVK to scheme?
 			informer, err := s.cache.GetInformerForKind(s.ctx, newRes.GroupVersionKind)
 			if err != nil {
-				// Log the error instead of panicking
 				klog.ErrorS(err, "Failed to create informer for resource", "gvk", newRes.GroupVersionKind, "err", err)
 				return
 			}
+
 			// if AddEventHandler returns an error, it is because the informer has stopped and cannot be restarted
 			if newRes.Registration, err = informer.AddEventHandler(handler); err != nil {
 				if s.ctx.Err() != nil {
@@ -173,8 +167,8 @@ func (s *informerManagerImpl) AddDynamicResources(dynResources []APIResourceMeta
 		if !newGVKs[gvk] && !dynRes.isStaticResource {
 			informer, err := s.cache.GetInformerForKind(s.ctx, dynRes.GroupVersionKind)
 			if err != nil {
-				//handle error
-				panic(err)
+				klog.ErrorS(err, "Failed to get informer for resource", "gvk", dynRes.GroupVersionKind, "err", err)
+				return
 			}
 			if err := informer.RemoveEventHandler(dynRes.Registration); err != nil {
 				if s.ctx.Err() == nil {
@@ -185,7 +179,6 @@ func (s *informerManagerImpl) AddDynamicResources(dynResources []APIResourceMeta
 			}
 			obj, err := s.scheme.New(gvk)
 			if err != nil {
-				// handle error
 				klog.V(2).ErrorS(err, "Could not get object of a disappeared resource", "res", dynRes)
 			}
 			err = s.cache.RemoveInformer(s.ctx, obj.(client.Object))
@@ -215,12 +208,10 @@ func (s *informerManagerImpl) AddStaticResource(resource APIResourceMeta, handle
 	s.apiResources[resource.GroupVersionKind] = &resource
 	informer, err := s.cache.GetInformerForKind(s.ctx, resource.GroupVersionKind)
 	if err != nil {
-		//handle error
 		klog.V(2).ErrorS(err, "Failed to create informer for resource", "gvk", resource.GroupVersionKind)
 	}
 	resource.Registration, err = informer.AddEventHandler(handler)
 	if err != nil {
-		//handle error
 		klog.V(2).ErrorS(err, "Failed to add event handler for resource", "gvk", resource.GroupVersionKind)
 	}
 }
@@ -229,7 +220,6 @@ func (s *informerManagerImpl) IsInformerSynced(resource schema.GroupVersionKind)
 	// TODO: use a lazy initialized sync map to reduce the number of informer sync look ups
 	informer, err := s.cache.GetInformerForKind(s.ctx, resource)
 	if err != nil {
-		//handle error
 		klog.V(2).ErrorS(err, "Failed to get informer for resource", "gvk", resource)
 	}
 	return informer.HasSynced()