Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): 🆕 add hero image to blog articles #81

Merged
merged 21 commits into from
Oct 23, 2024
Merged

feat(ui): 🆕 add hero image to blog articles #81

merged 21 commits into from
Oct 23, 2024

Conversation

brklntmhwk
Copy link
Owner

@brklntmhwk brklntmhwk commented Oct 18, 2024 •
edited
Loading

Changes

  • Install @unpic/astro as a dev dep
    • didn't work due to the Astro SSR & dependencies related issue
  • Apply it to the image service in astro.config.ts
  • Add the hero image prop to the blog content schema
    • Done but it's temporarily unused
  • Add the image type field to the blog content fields in frontmatter.json
  • Add the hero image section to the blog layout
    • Temporarily commented out
  • Add hero images to some blog articles

These are tasks that were not planned first but have been done in this PR:

  • Refactor Image & Card components
  • Refactor remark plugins for images and cards
  • Add blur-hashes to the Unsplash photos on the homepage

Checklist

  • UI layout collapse

Notes

  • Add some items to the tools page along the way

@brklntmhwk
chore(ui): 🤖 add unpic
823b489 
add a lib for image optimization unpic

✅ Closes: #80
@brklntmhwk
feat(ui): 🆕 add hero image section to blog layout
f2aaced 
add the hero image prop to the blog config and the image type field to
frontmatter json config

✅ Closes: #80
@brklntmhwk brklntmhwk self-assigned this Oct 18, 2024
@brklntmhwk brklntmhwk linked an issue Oct 18, 2024 that may be closed by this pull request
Add unpic (Image related lib) #80
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 18, 2024 •
edited
Loading

Deploying younagidev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38ab5e9
Status: ✅  Deploy successful!
Preview URL: https://ab3ee979.my-astro-blog-4xp.pages.dev
Branch Preview URL: https://80-add-unpic-image-related-l.my-astro-blog-4xp.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Warnings
⚠️

⚠️ PR size appears relatively large.

Preferably, break changes into separate PRs for faster and easier code review.

  - Changed files: 168

  - Changed lines: 838

Generated by 🚫 dangerJS against 38ab5e9

@brklntmhwk
refactor(none): ✨ arrange under the components directory
6078032
@brklntmhwk
chore(config): 🤖 tweak biome settings
552e704
@brklntmhwk
fix(ui): 🐛 modify wrong paths to some components
206dbdf
@brklntmhwk
refactor(none): ✨ move unified plugins to under lib/unified
8021eaf 
✅ Closes: #80
@brklntmhwk
fix(none): 🐛 fix import paths
4dacda6
@brklntmhwk
fix(none): 🐛 fix import paths
64712f8 
✅ Closes: #80
@brklntmhwk
refactor(overall): ✨ tweak image optimization & card component parts
fda0771 
✅ Closes: #80
@brklntmhwk
refactor(overall): ✨ make the remark card plugin configurable
9327130 
✅ Closes: #80
@brklntmhwk
refactor(ui): ✨ add blurred placeholders to external images
cff2228 
✅ Closes: #80
@brklntmhwk
refactor(ui): ✨ add blurred placeholders to external images
7f96648 
✅ Closes: #80
@brklntmhwk
refactor(ui): ✨ add blurhash to Unsplash photos
38ab5e9 
leverage the blur_hash prop provided by the Unsplash photo API and apply
the placeholder after uri conversion

✅ Closes: #80
@brklntmhwk brklntmhwk merged commit 611ccde into main Oct 23, 2024
7 checks passed
@brklntmhwk brklntmhwk deleted the 80-add-unpic-image-related-lib branch October 23, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brklntmhwk brklntmhwk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unpic (Image related lib)
1 participant
@brklntmhwk