Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-background WDL: workflow can fail if some outputs are not created #68

Closed
sjfleming opened this issue Aug 19, 2020 · 2 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sjfleming
Copy link
Member

sjfleming commented Aug 19, 2020

If there is any error that prevents an output file from being created, for example the output PDF, this is handled gracefully by cellbender. However, it is not handled gracefully by WDL, which only allows "required" outputs. If one of these outputs does not exist, the workflow fails.

Proposed solution:
In the WDL, ensure each file exists before the task ends. This might amount to just a couple of bash

touch filename

commands.

@sjfleming sjfleming added the bug Something isn't working label Aug 19, 2020
@sjfleming sjfleming added this to the v0.2 milestone Aug 19, 2020
@sjfleming sjfleming self-assigned this Aug 19, 2020
@sjfleming
Copy link
Member Author

Also need to handle trailing slashes for the input called output_directory, because the current behavior is to insert an extra trailing slash, regardless of whether one already exists. This leads to unexpected behavior.

@sjfleming sjfleming modified the milestones: v0.2, v0.2.1 May 3, 2021
@sjfleming sjfleming mentioned this issue Mar 28, 2023
@sjfleming sjfleming mentioned this issue Aug 6, 2023
@sjfleming
Copy link
Member Author

Closed by #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant