Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Amazon Athena #408

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

brendan-cook-87
Copy link

Overview

Adds support Amazon Athena.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?


Adding Amazon Athena support as per feature request.

Outstanding questions

I am a bit unsure about a few pieces of the dbt_project config. I have added table_type and incrememntal_strategy config conditionally for Athena, but I haven't tested how these affect other databases.

The additional config in the incremental test model is required because by default in Athena if you cast 'apple' to varchar the default response creates a varchar(5) column which doesn't accept a varchar(6) - 'banana', unless you select a table_type that allows for (some) schema evolution (iceberg).

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • Athena
  • N/A

@brendan-cook-87 brendan-cook-87 temporarily deployed to Approve Integration Tests November 27, 2023 06:14 — with GitHub Actions Inactive
@brendan-cook-87 brendan-cook-87 temporarily deployed to Approve Integration Tests November 27, 2023 06:14 — with GitHub Actions Inactive
@brendan-cook-87 brendan-cook-87 temporarily deployed to Approve Integration Tests November 27, 2023 06:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant