Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sql-server tests for dbt 1.3.0 to 1.8.0 #445

Closed
wants to merge 20 commits into from
Closed

Added sql-server tests for dbt 1.3.0 to 1.8.0 #445

wants to merge 20 commits into from
+145 −16

Conversation

KijkEr
Copy link

@KijkEr KijkEr commented Sep 25, 2024 •
edited
Loading

Overview

Fix and add sql-server tests scenarios.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • SQL Server
  • N/A

@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:01 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:01 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:01 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:01 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Inactive
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 25, 2024 19:06 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:41 — with GitHub Actions Failure
@mtcarlone mtcarlone temporarily deployed to Approve Integration Tests October 4, 2024 17:41 — with GitHub Actions Inactive
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:41 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:47 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:47 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:47 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:47 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:48 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:48 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:48 — with GitHub Actions Failure
@mtcarlone mtcarlone had a problem deploying to Approve Integration Tests October 4, 2024 17:48 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 16:40 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 16:40 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 16:40 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 16:40 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 19:54 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 19:54 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 19:54 — with GitHub Actions Failure
@michelley-an michelley-an had a problem deploying to Approve Integration Tests October 7, 2024 19:54 — with GitHub Actions Failure
@KijkEr
Copy link
Author

KijkEr commented Oct 8, 2024

Anything I can do to help here? I got the postgres tests to work in my repo. See my last comment.

@michelley-an
Copy link
Contributor

We released a new version yesterday to fix the postgres bug, I'll create a new PR with your changes shortly

michelley-an pushed a commit to michelley-an/dbt_artifacts that referenced this pull request Oct 9, 2024
@michlyan
testing brooklyn-data#445
e1858b8
@michelley-an michelley-an mentioned this pull request Oct 9, 2024
Merged
13 tasks
llifoawing added a commit that referenced this pull request Oct 31, 2024
@llifoawing
Merge pull request #450 from michelley-an/main
e51649f 
Testing #445 - adding sqlserver integration tests
@michelley-an
Copy link
Contributor

closing this now - we added the changes in a new PR and merged successfully. Will update the version later today, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelley-an michelley-an michelley-an left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KijkEr @michelley-an @mtcarlone @bvkabn