Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment version to 2.7.1 #457

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

michelley-an
Copy link
Contributor

Overview

PR to increment version and release a minor update.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

Copy link
Member

@llifoawing llifoawing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci_test_package gha failed 🤔 I'm thinking the run statements shouldnt be nested within the matrix block maybe?

@mtcarlone
Copy link
Contributor

@michelley-an , @llifoawing is right - we need to move the runs-on out of the matrix property and adjust how we're using environment

It should be either:

  integration-sqlserver-single-run:
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false # Don't fail one DWH if the others fail
      matrix:
        # When supporting a new version, update the list here
        version: ["1_3_0", "1_4_0", "1_7_0", "1_8_0"]
        run: tox -e integration_sqlserver_${{ matrix.version }}
        environment: [Approve Integration Tests]

or

  integration-sqlserver-single-run:
    runs-on: ubuntu-latest
    environment: 
      name: Approve Integration Tests
    strategy:
      fail-fast: false # Don't fail one DWH if the others fail
      matrix:
        # When supporting a new version, update the list here
        version: ["1_3_0", "1_4_0", "1_7_0", "1_8_0"]
        run: tox -e integration_sqlserver_${{ matrix.version }}

I think we can either tack it onto this version PR or cut a new one 🤷 either/or

@michelley-an michelley-an temporarily deployed to Approve Integration Tests November 5, 2024 17:09 — with GitHub Actions Inactive
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:12 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:18 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:25 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:27 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:34 — with GitHub Actions Waiting
@michelley-an michelley-an temporarily deployed to Approve Integration Tests November 5, 2024 17:39 — with GitHub Actions Inactive
@michelley-an michelley-an deployed to Approve Integration Tests November 5, 2024 17:48 — with GitHub Actions Active
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 17:52 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 18:09 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 18:12 — with GitHub Actions Waiting
@michelley-an michelley-an requested a deployment to Approve Integration Tests November 5, 2024 18:14 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants