refactor spec

broothie · Apr 23, 2022 · 7bd4d8d · 7bd4d8d
1 parent 4ac8bb8
commit 7bd4d8d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/jobs/message_deletion_job.rb b/app/jobs/message_deletion_job.rb
@@ -1,6 +1,8 @@
 class MessageDeletionJob
   include Sidekiq::Worker
 
+  MAX_MESSAGE_COUNT = ENV.fetch('MAX_MESSAGE_COUNT', 9000).to_i
+
   def perform
     message_surplus = Message.count - max_message_count
     return if message_surplus <= 0
@@ -16,6 +18,6 @@ def perform
   private
 
   def max_message_count
-    ENV.fetch('MAX_MESSAGE_COUNT', 9000).to_i
+    MAX_MESSAGE_COUNT
   end
 end
diff --git a/spec/jobs/message_deletion_job_spec.rb b/spec/jobs/message_deletion_job_spec.rb
@@ -8,7 +8,7 @@
   let(:messages) { Array.new(count) { FactoryBot.create(:message, channel: channel) } }
 
   before do
-    allow(ENV).to receive(:fetch).with('MAX_MESSAGE_COUNT', 9000).and_return(max)
+    allow(job).to receive(:max_message_count).and_return(max)
 
     messages
   end