refactor: put MMP into subroute #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-bessey
commented
Mar 5, 2025
| {href: "/study-design", title: "Study Design"}, | ||
| {href: "/data", title: "Data"}, | ||
| {href: "/documentation", title: "Documentation"},] | ||
| {href: "mmp/people", title: "People"}, |
There was a problem hiding this comment.
should be /mmp/people
There was a problem hiding this comment.
also should append elsewhere instead of defining bother LAMP and MMP here
s-bessey
commented
Mar 5, 2025
| </div> | ||
| </Home>) | ||
| <Home | ||
| title="MMP/LAMP" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I think I understood what I was doing. Right now, there's a very ugly new landing page, mostly to make sure that my routing was working. I think that
Header.tsxandconsts.txwill need to be updated to allow for differing paths? I also didn't nest Documentation and Data -- wasn't sure on those