Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi-chunk extracts + prompt updates #89

Merged
merged 47 commits into from
Oct 4, 2024
Merged

Conversation

navidkpr
Copy link
Collaborator

@navidkpr navidkpr commented Oct 3, 2024

why

what changed

test plan

@navidkpr navidkpr changed the title fix bug: now we properly support multi-chunk extracts support multi-chunk extracts Oct 3, 2024
@navidkpr navidkpr changed the title support multi-chunk extracts support multi-chunk extracts + prompt updates Oct 3, 2024
await stagehand.init();

try {
// await stagehand.page.goto("https://www.homedepot.com/");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidkpr we also need to test that the search bar works (uncomment this) and that stagehand finds the best selling grill by itself - this makes this eval even harder but I think we should solve it

);

console.log("Local browser started successfully.");

await applyStealthScripts(context);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might help with the Costar eval which does not work in headless mode!

@@ -9,7 +9,7 @@ You are given:
2. the steps that have been taken so far
3. a list of active DOM elements in this chunk to consider to accomplish the goal.

You have 2 tools that you can call: doAction, and skipSection
You have 2 tools that you can call: doAction, and skipSection. Do action only performs Playwright actions. Do not perform any other actions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this helps with me previously writing edge cases

@pkiv pkiv merged commit ca03d91 into main Oct 4, 2024
1 check passed
@filip-michalsky filip-michalsky deleted the npour/fix-bananalyzer-3 branch October 6, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants