Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wormhole references #459

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Remove wormhole references #459

merged 4 commits into from
Aug 14, 2023

Conversation

XapaJIaMnu
Copy link
Collaborator

Should fix #421
I am not sure if the import intgemm as a separate step is still a thing though.

@XapaJIaMnu XapaJIaMnu changed the title Remove warmhole references Remove wormhole references Aug 13, 2023
@jelmervdl
Copy link
Member

There's the try linking to mozilla's native intgemm bit, but I don't think there's any wormhole code in the module itself.

WebAssembly.instantiateStreaming(response, {
...info,
'wasm_gemm': this.options.useNativeIntGemm
? this.linkNativeIntGemm(info)
: this.linkFallbackIntGemm(info)
}).then(({instance}) => accept(instance)).catch(reject);

I don't think we ever had a wasm binary that didn't use SIMD instructions to support very old machines for which Firefox doesn't support those. (But I don't know if Firefox supports those machines anyway anymore)

@kpu
Copy link
Member

kpu commented Aug 13, 2023

There's the try linking to mozilla's native intgemm bit, but I don't think there's any wormhole code in the module itself.

WebAssembly.instantiateStreaming(response, {
...info,
'wasm_gemm': this.options.useNativeIntGemm
? this.linkNativeIntGemm(info)
: this.linkFallbackIntGemm(info)
}).then(({instance}) => accept(instance)).catch(reject);

I think some form of that is intended for production. At least, they sent me a rewrite of intgemm for multiple architectures.

I don't think we ever had a wasm binary that didn't use SIMD instructions to support very old machines for which Firefox doesn't support those. (But I don't know if Firefox supports those machines anyway anymore)

Agreed, we didn't. And if we did, it would have been to support Safari, which we decided to wait on until they added SIMD...

@XapaJIaMnu XapaJIaMnu merged commit 534ed37 into main Aug 14, 2023
18 checks passed
@XapaJIaMnu XapaJIaMnu deleted the update_wasm_instructions branch August 14, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove wormhole references
3 participants