Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make program exit gracefully when binding fails. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richard-uk1
Copy link
Contributor

Also give good error message when address is in use.

I've reopened this PR. If you want to test it before merging

git remote add derekdreery https://github.com/derekdreery/basic-http-server
git fetch derekdreery
git checkout derekdreery/handle_addr_in_use

(I hate looking up git commands so I thought I'd save you the trouble :P)

It should work - I'm not sure why it wasn't for you. Maybe it was to do with a merge artifact, which this shouldn't exhibit since it's rebased on master.

Also give good error message when address is in use.
@richard-uk1 richard-uk1 mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant