Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hide behavior #106

Merged
merged 10 commits into from
Jul 30, 2023
Merged

Fix hide behavior #106

merged 10 commits into from
Jul 30, 2023

Conversation

bruceharrison1984
Copy link
Owner

@bruceharrison1984 bruceharrison1984 commented Jul 30, 2023 •
edited
Loading

This seeks to address the inconsistent behavior of hidden events in relation to the onMoreEvents handler.

@github-actions
Copy link

github-actions bot commented Jul 30, 2023 •
edited
Loading

Coverage Report for ./packages/Schedulely

Status Category Percentage Covered / Total
🔵 Lines 86.9% 1354 / 1558
🔵 Statements 86.9% 1354 / 1558
🔵 Functions 86.04% 37 / 43
🔵 Branches 94.07% 127 / 135
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/Schedulely/src/components/defaultHeader/DefaultHeader.tsx 100% 100% 100% 100%
packages/Schedulely/src/layouts/eventWeekLayout/EventWeekLayout.tsx 100% 87.5% 80% 100%
packages/Schedulely/src/layouts/monthLayout/MonthLayout.tsx 100% 100% 100% 100%
packages/Schedulely/src/providers/ActionProvider.tsx 100% 100% 100% 100%
packages/Schedulely/src/providers/CalendarProvider.tsx 86.36% 100% 100% 86.36% 81-90, 94-103, 123, 128-130
packages/Schedulely/src/providers/EventIntersectionProvider.tsx 17.74% 100% 0% 17.74% 23-124
packages/Schedulely/src/types/state/EventIntersectionContextState.ts 100% 100% 100% 100%
Generated in workflow #62

@bruceharrison1984 bruceharrison1984 linked an issue Jul 30, 2023 that may be closed by this pull request
Hidden events are incorrectly labeled #105
Closed
@bruceharrison1984 bruceharrison1984 merged commit 68a5cd6 into main Jul 30, 2023
3 checks passed
@bruceharrison1984 bruceharrison1984 deleted the fix-hide-behavior branch July 30, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hidden events are incorrectly labeled
1 participant
@bruceharrison1984