Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins list x32 - web interface - bug when unchecking Run when Notepad++ is closed #96

Open
jcaillon opened this issue Mar 5, 2018 · 2 comments

Comments

@jcaillon
Copy link

jcaillon commented Mar 5, 2018

Hello,

Thank you for developing nppPluginManager.

Context

I'm facing a problem updating info on my plugin here : https://npppm.bruderste.in/plugins.
The plugin is 3P - Progress Programmers Pal, it is developed in C# and previously required .net 4.0.
For several reasons i need to now target .net 4.6.2 so i have included a small program to check the current installed version of .net and install an update if needed.

Description of the Issue

I want to "RUN" a program after downloading and copying required files.
But each time I add a "run" step, the plugin doesn't save correctly. I basically saves until the run step, and everything after the run is lost. E.G. i put 2 delete in the "remove" section, those are lost when I save with a run step.

I tried uploading an xml but it just doesn't work either :/

[EDIT] the bug only appears if Run when Notepad++ is closed is un-checked

image

Steps to Reproduce the Issue

Add a "run" step and don't check Run when Notepad++ is closed, click "edit plugin" to save it. Edit the plugin again, run step as disappeared.

Expected xml

<?xml version="1.0" encoding="UTF-8"?>
<plugins>
   <plugin name="3P - Progress Programmers Pal">
      <unicodeVersion>1.8.1</unicodeVersion>
      <aliases>
         <alias name="3P" />
      </aliases>
      <description>[Requires .net framework 4.6.2]\n\n3P is a notepad++ plug-in designed to help writing OpenEdge ABL (formerly known as Progress 4GL) code. It provides :\n\n- a powerful auto-completion\n- tool-tips on every words\n- a code explorer to quickly navigate through your code\n- a file explorer to easily access all your sources\n- the ability to run/compile and even PROLINT your source file with an in-line visualization of errors\n- more than 50 options to better suit your needs\n- and so much more!\n\nVisit http://jcaillon.github.io/3P/ for more details on the plugin</description>
      <author>Julien Caillon</author>
      <homepage>http://jcaillon.github.io/3P/</homepage>
      <sourceUrl>https://github.com/jcaillon/3P</sourceUrl>
      <latestUpdate>More infos here :\nhttps://github.com/jcaillon/3P/releases/tag/v1.8.1</latestUpdate>
      <stability>Good</stability>
      <install>
         <unicode>
            <download>https://github.com/jcaillon/3P/releases/download/v1.8.1/3P.zip</download>
            <copy from="3P.dll" to="$PLUGINDIR$\" validate="true" />
            <run file="NetFrameworkChecker.exe" arguments="-ShowOnlyIfNotInstalled" outsideNpp="0" />
         </unicode>
      </install>
      <remove>
         <unicode>
            <delete file="$PLUGINDIR$\3P.dll" />
         </unicode>
      </remove>
   </plugin>
</plugins>

Validation :

"3P - Progress Programmers Pal":
    {
        "94ffc9d97d2c1437a66a5e9312d22d3a": "3P.dll",
        "d303f05a3de2c11d830743a255732411": "NetFrameworkChecker.exe"
    }
@chcg
Copy link
Collaborator

chcg commented Mar 5, 2018

@jcaillon I think this is an issue in the WebInterface, I also faced with https://npppm.bruderste.in/plugins/view/notepadstarterplugin. If I remember correctly I had to check "Run when Notepad++ is closed"

@jcaillon
Copy link
Author

jcaillon commented Mar 5, 2018

Hi @chcg, thanks for the feedback!
And... you were right! It indeed saves correctly when checking "Run when Notepad++ is closed".

Normally, this would be a problem for me because I actually need this program BEFORE notepad++ is restarted.
However... It doesn't work like that! It seems that there is a bug in the plugin manager because this 0/1 toggle doesn't do anything. Even with this option checked the program is executed before the restart!

I'll open a second issue for this.

Thanks again!

@jcaillon jcaillon changed the title Plugin manager - plugins list Plugins list x32 - web interface - bug when unchecking Run when Notepad++ is closed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants