Update ping to use ping6 when ip is type ipv6 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,10 +150,9 @@ impl Target for IcmpTarget { | |||
| // Using ping seems to be the easiest way to send ICMP packets without root privileges | |||
| let available_via_ping = |addr: IpAddr| { | |||
| if addr.is_ipv6() { | |||
| Command::new("ping") | |||
| Command::new("ping6") | |||
There was a problem hiding this comment.
As much as I like the change ping6 is neither available on my windows and on my linux maschine. Both support ping with "-6". You should check whats available before executing it.
|
Sorry for not noticing you PR for some time. Github just overwhelms me with messages and I haven't touched the codebase in ages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.