-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #9
base: master
Are you sure you want to change the base?
Develop #9
Conversation
…n auto increment field. also change folder to be varchar 255, fixing issue on index create. changed datatype on scriptnumber column to int to allow for representing date as number, e.g. 2014121601
Hi Tony, Thanks for the PR. Just to let you know that I'll try and look into this in the next few days, ok? Bruno |
Thanks, Bruno. I didn't mean to be harsh in my comments. I really appreciate the work you I will be working on fixing some of the build and/or run issues caused by Regards, On Wed, Dec 17, 2014 at 4:21 AM, Bruno Lopes [email protected]
Tony Briscolino T 630-654-0170 x 147 We help |
…ase field type change in version table
…bedded resource as a fallback. copy paste from brunomlopes@af5f15d
Load provider file from current directory
…ion required property.
Hi Bruno,
I forked your 2.2.0.0 branch. It kept throwing errors while attempting to deploy to mysql directly. I am working in version 5.6.21 of MySql. The functional change I made was in mysql_apply.vm. The GetDate() syntax doesn't exist in 5.6.21 - it wanted current_timestamp(). I also upgraded NAnt since my CI server uses 0.92, but I didn't make any changes to your code that require it. There are more modified files than this since your repo has mixed line breaks. I converted as many as I could do automatically to UNIX line feeds and committed those.
Although the code builds, it doesn't run successfully on all machines. The reason for this is that it relies on a bunch of assemblies that you must have installed in your GAC. I believe it is a better practice to distribute them directly. If you don't want to do that, I suggest at least documenting the required assemblies (this is another reason that I upgraded NAnt).
I found your project because I was looking for a way to automate mysql deployment so your code is VERY useful. It was disappointing to me that the examples were all MSSQL based. Your introduction also talks about how the code can be called through msbuild and nant, yet doesn't provide a clear example.
Regards,
Tony