-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/465 cmd config rework #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Strips out the usage of setup() and global flag binding from index and update-epochs commands 2. Beginning to build out config structs to build common/specific config values per-command 3. Proper setup of command specific flag configs for index and update-epochs 4. TODO: do (3) for query and update-denoms commands
…d values and move to new config types
…uirements when enabled
…gs into new base config for use in multiple commands
Hey, lets run over this in person before i merge it in as you suggested. |
This was referenced Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of this PR
This PR completely reworks the way commands receive the configuration values associated with them. It does this by splitting each command configuration out into its own block, allowing for per-command configuration requirements.
Old Methods
The old method used a single configuration setup for the entire application. This means every command required the exact same configuration, with each command only using the configs it needed to.
The commands also used the same
setup
function, which was an end-to-end setup of database connections, loggers etc...New Methods
This PR introduces the following new behavior:
setup
function, each command only sets up what it needsThis achieves the following:
--help
output for each command