Pass steps always set operation's success to true. (#3)

bryanrite · Sep 7, 2023 · 24ac9ef · 24ac9ef
1 parent ca05244
commit 24ac9ef
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/operational/operation.rb b/lib/operational/operation.rb
@@ -34,6 +34,7 @@ def self.call(state={})
           raise UnknownStepType
         end
 
+        result = true if type == :pass
         instance.instance_variable_set(:@_operational_succeeded, result ? true : false)
         instance.instance_variable_get(:@_operational_path) << (result ? true : false)
 

diff --git a/spec/operational/operation_spec.rb b/spec/operational/operation_spec.rb
@@ -175,5 +175,17 @@ def step3(state)
     it "sets the result boolean" do
       expect(OpClass.call.succeeded?).to eq true
     end
+
+    context "when ending in a pass step" do
+      let(:op_class) do
+        Class.new(described_class) do
+          pass ->(state) { state[:track] = [1]; false }
+        end
+      end
+
+      it "sets succeeded as true" do
+        expect(OpClass.call.succeeded?).to eq true
+      end
+    end
   end
 end