Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Update test vectors with normalized S value sigs #130

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

brycx
Copy link
Owner

@brycx brycx commented Aug 16, 2024

closes #122

Before this change, we had the signatures generated by v3.public be tested to be reproducible. Such that we given the same input could generate the same token. This is possible because we employ deterministic nonces.

New test vectors for v3.public have been issued (https://github.com/paseto-standard/test-vectors/releases/tag/v1.3.0) to only include low-S/normalized S. These test vectors we can't reproduce the tokens for, and thus that part of the tests have been removed. Justification of removal:

Note: During tests with the new vectors and using elliptic-curve's provided normalize_s() internally for the signature, didn't reproduce either, suggesting maybe the new test vectors were generated non-deterministically or the normalization routine used in generation of them differed somehow.

@brycx brycx merged commit fb2a0f3 into master Aug 16, 2024
16 checks passed
@brycx brycx deleted the updated-v3public branch August 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test vectors for v3.public
1 participant