Reimplement MPS and MPO
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top of recent changes
…PS`, `MPO`, `PEPS`
…nsors) (#218) * Format code * Implement MPS identity initialization * Add tests for all dispatches of MPS identity init * Format julia code * Rename function header & add docstring * Fix test set for identity MPS * Format code * Rewrite MPS identity init function to nsites instead of arrays' dimensions * Format julia code * Update docstring of identity * Clean code in test (suggested by Jofre) Co-authored-by: Jofre Vallès Muns <[email protected]> * Format julia code * Refactor virtualdims in identity (suggested by Sergio) * Update src/Ansatz/MPS.jl * Restrict to default order in identity MPS * Update src/Ansatz/MPS.jl * Remove order parameter in identity --------- Co-authored-by: Jofre Vallès Muns <[email protected]> Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do on subsequent PRs:
Lattice#234MPS/MPOmethodsAbstractAnsatz#235normalize!for theCanonicalform ofAbstractMPO#236mixed_canonize!based on form #238canonize!based on form #239reindex!when number of sites do not match on left and right hand sides #240merge!preserves involved output indices of firstQuantumor lastQuantum#243replace!onAbstractQuantumwith already existing index #244