Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: USB Support #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature: USB Support #140

wants to merge 1 commit into from

Conversation

gronke
Copy link
Member

@gronke gronke commented Sep 25, 2017

  • allows to expose USB devices via allow_usb configuration
  • Define individual device(s)

@gronke gronke force-pushed the feature/share-usb branch 2 times, most recently from f6c95eb to 6c3f3e3 Compare September 25, 2017 22:38
gronke
gronke commented Sep 26, 2017
View reviewed changes
iocage/lib/Jail.py Outdated
devfs_ruleset.append("add path 'bpf*' unhide")

if self.config["allow_usb"] is True:
devfs_ruleset.append("add path 'usb/*' unhide")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to investigate the security impact by unhiding /dev/usb/*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this even necessary after the lines below?

@gronke gronke force-pushed the feature/share-usb branch 2 times, most recently from 7bd47fa to e887c50 Compare November 25, 2017 14:53
@gronke gronke force-pushed the feature/share-usb branch 3 times, most recently from dad14f5 to e2c59f9 Compare August 12, 2018 16:14
@gronke gronke mentioned this pull request Feb 3, 2019
Closed
@igalic igalic mentioned this pull request Feb 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic left review comments

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gronke @igalic