-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor Resource namespace #577
base: master
Are you sure you want to change the base?
Conversation
gronke
commented
Nov 10, 2018
- groups Resource in a module directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is our hierarchy so deep & complicated to begin with?
@@ -413,3 +413,16 @@ def destroy( | |||
def save(self) -> None: | |||
"""Save changes to the default configuration.""" | |||
self._write_config(self.config.user_data) | |||
|
|||
|
|||
iocage.hook_module( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a python thing, or a (lib)iocage thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A local workaround for ugly Python module names. Makes them callable and act like classes with the same names.
Is this done and can be tested or some work still required? |
@urosgruber unfortunately, @gronke has been burried under real life, paid work, so this hasn't been touched since, and i'm fairly certain it needs some more work before it can be tested. Unless you feel particularly adventures 😅 |
@igalic thanks for the update. Anyone knows how long will it take for this project to continue with it's pace. I notice it was a bit quiet here lately. I would help here but I'm very rookie around Python so I doubt there is anything I can do except testing. |
As @igalic already has pointed out I've put focus on paid work, so that I was entirely booked in the past two month. This will continue in December and January and is necessary to secure my independence developing the lib, as done the year before. I am not sleeping, just breathing. The community around libiocage is small, but all the feedback, reviews and contributions motivate me to continue with the same quality objectives in mind. Speaking up here on GitHub is now more important than ever before - please stay alerted on the https://github.com/iocage/iocage/tree/v2 branch as well, because this is where shit will hit the fan. |
@gronke really appreciate your hard work and quick turnarounds. |
i still really like this work! |