Change PDO.php #709
Open
Change PDO.php #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return either default scopes set to client from client table or return global default scopes from scope table
bshaffer
reviewed
Dec 23, 2016
| $clientScope = $this->getClientScope($client_id); | ||
| if (!is_null($clientScope)) { | ||
| $getGlobalDefaults = false; | ||
| $defaultScopes = explode(' ', trim($clientScope)); |
There was a problem hiding this comment.
let's return $clientScopes here and remove the $getGlobalDefaults variable all together. This will greatly simplify this function.
|
We also need test coverage for this. Are you willing to add this? It will also verify if this issue is happening in the other storage classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDO's getDefaultScope not returning the client's (default) scope
When getting the default scope from the database using PDO, the
getDefaultScopefunction neglects the$client_idprovided, instead of returning the client's scope from the client table.So I added that using the
getClientScopefunction. Now it returns either default scopes set to client from client table or returns global default scopes from scope table.I'm not sure if this should also be changed in other storage classes.