ovn: remove redundant removes for ready status when disabled

It is removed in the main reconcile entrypoint, so there is no need to remove it inside per-CRD reconcile functions.
bshephar · Feb 12, 2024 · c13dcf8 · c13dcf8
1 parent 9f8dc75
commit c13dcf8
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/pkg/openstack/ovn.go b/pkg/openstack/ovn.go
@@ -73,7 +73,6 @@ func ReconcileOVNDbClusters(ctx context.Context, instance *corev1beta1.OpenStack
 			if _, err := EnsureDeleted(ctx, helper, OVNDBCluster); err != nil {
 				return false, err
 			}
-			instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneOVNReadyCondition)
 			continue
 		}
 
@@ -121,7 +120,6 @@ func ReconcileOVNNorthd(ctx context.Context, instance *corev1beta1.OpenStackCont
 		if _, err := EnsureDeleted(ctx, helper, OVNNorthd); err != nil {
 			return false, err
 		}
-		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneOVNReadyCondition)
 		return false, nil
 	}
 
@@ -170,7 +168,6 @@ func ReconcileOVNController(ctx context.Context, instance *corev1beta1.OpenStack
 		if _, err := EnsureDeleted(ctx, helper, OVNController); err != nil {
 			return false, err
 		}
-		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneOVNReadyCondition)
 		return false, nil
 	}