[openstackclient] re-create pod when NodeSelector changes

When the NodeSelector gets updated via the OpenStackClient NodeSelector api we have to re-create the pod that it gets scheduled for the new configuration Jira: OSPRH-9443 Signed-off-by: Martin Schuppert <[email protected]>
bshephar · Aug 16, 2024 · e8ad1cd · e8ad1cd
1 parent 99a1e96
commit e8ad1cd
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/controllers/client/openstackclient_controller.go b/controllers/client/openstackclient_controller.go
@@ -17,6 +17,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"reflect"
 	"time"
 
 	"github.com/go-logr/logr"
@@ -342,8 +343,14 @@ func (r *OpenStackClientReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 					osclient.Name,
 					errors.New("Config changed recreate pod"), // Specify the error message
 				)
+			case !reflect.DeepEqual(osclient.Spec.NodeSelector, instance.Spec.NodeSelector):
+				// if NodeSelector change force re-create by triggering NewForbidden
+				return k8s_errors.NewForbidden(
+					schema.GroupResource{Group: "", Resource: "pods"}, // Specify the group and resource type
+					osclient.Name,
+					errors.New("Cannot update Pod spec field - Spec.NodeSelector"), // Specify the error message
+				)
 			}
-
 		}
 
 		osclient.Labels = util.MergeStringMaps(osclient.Labels, clientLabels)