[Tizen.Core] Fix double free issues (Samsung#6335)

* [Tizen.Core] Fix double free issues The received object in the callback function should not be released. Signed-off-by: Hwankyu Jhun <[email protected]> * Prevent double free using an internal property Signed-off-by: Hwankyu Jhun <[email protected]> --------- Signed-off-by: Hwankyu Jhun <[email protected]>
bshsqa · Sep 25, 2024 · bb6075f · bb6075f
1 parent 8fe84ca
commit bb6075f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/Tizen.Core/Tizen.Core/ChannelObject.cs b/src/Tizen.Core/Tizen.Core/ChannelObject.cs
@@ -55,12 +55,14 @@ public ChannelObject(int id, object data)
             Id = id;
             Data = data;
             IsUsed = false;
+            IsDestroyable = true;
         }
 
         internal ChannelObject(IntPtr handle)
         {
             _handle = handle;
             IsUsed = false;
+            IsDestroyable = true;
         }
 
         /// <summary>
@@ -128,6 +130,8 @@ public string Sender {
             }
         }
 
+        internal bool IsDestroyable { set; get; }
+
         internal bool IsUsed { set; get; }
 
         internal IntPtr Handle { get { return _handle; } }
@@ -152,7 +156,10 @@ protected virtual void Dispose(bool disposing)
                             _dataMap.TryRemove(id, out var data);
                         }
 
-                        Interop.LibTizenCore.TizenCoreChannel.ObjectDestroy(_handle);
+                        if (IsDestroyable)
+                        {
+                            Interop.LibTizenCore.TizenCoreChannel.ObjectDestroy(_handle);
+                        }
                         _handle = IntPtr.Zero;
                     }
                 }

diff --git a/src/Tizen.Core/Tizen.Core/Event.cs b/src/Tizen.Core/Tizen.Core/Event.cs
@@ -68,6 +68,7 @@ private bool EventHandlerCallback(IntPtr eventData, IntPtr userData)
             using (var eventObject = new EventObject(eventData))
             {
                 EventReceived?.Invoke(this, new EventReceivedEventArgs(eventObject));
+                eventObject.Handle = IntPtr.Zero;
             }
             return true;
         }

diff --git a/src/Tizen.Core/Tizen.Core/Task.cs b/src/Tizen.Core/Tizen.Core/Task.cs
@@ -567,6 +567,7 @@ private static void NativeChannelReceiveCallback(IntPtr nativeObject, IntPtr use
                         {
                             var eventArgs = new ChannelReceivedEventArgs(channelObject);
                             receiver.InvokeEventHandler(null, eventArgs);
+                            channelObject.IsDestroyable = false;
                         }
                     }
                 }