Correct counting of indirect-failed packages #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can now be tested separately.
This fixes a few typos introduced in the last set of commits. It also contains the result of "go mod tidy". The set of dependencies is a bit smaller now.
PkgsFromReport used to do two things: parse the machine-readable report and prune the dependencies to actually failed ones. Now it only does the former and is called ResultsFromReport. FixUpDependencies does the latter.
The new test tests only the parsing. A separate test tests the dependency pruning.
A package is now only considered to "break" another package if it is Failed or Prefailed, not IndirectFailed or IndirectPrefailed. So if a depends on b depends on c, and c failed to build, a's failed dependency is c, not b. (There is a test for exactly this!) This matches how pbulk does it and is more correct and useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
This changes the algorithm to determine failed dependencies like
pbulkdoes.A package is now only considered to "break" another package if it is Failed or Prefailed, not IndirectFailed or IndirectPrefailed.
So if
adepends onbdepends onc, andcfailed to build,a's failed dependency isc, notb. There is a test for exactly this!Tested locally. The test dataset looks very different now!
NB: Once deployed, this will only be used in newly published build reports. Older ones will continue using the old method.