This repository has been archived by the owner on May 31, 2023. It is now read-only.
Android refactor and fixes #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMcIntosh
force-pushed
the
master
branch
from
5500133 to
560048c
Compare
|
Hi @btastic, any chance of a review and merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a pretty basic refactor for Android to push each operation into it's own method and leave the
onMethodCallto handle getting the arguments and calling the required method.The import for ExifInterface has been changed to use the
AndroidXversion.The
build.gradlehas a couple house cleaning changes too.The following tickets are addressed:
#55
#92