Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use secp256k1 library with system #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

use secp256k1 library with system #1

wants to merge 7 commits into from

Conversation

jjz
Copy link

@jjz jjz commented Jul 3, 2017

Used in the system of library . not local library
So secp256k1-go no longer need to use submodulehttps://github.com/bitcoin-core/secp256k1 , We can use the secp256k1-go as a cgo library . Users need to compile their own installation secp256k1(c)

@afk11
Copy link
Contributor

afk11 commented Jul 4, 2017

Great suggestion, however upstream does not use versioning (so git submodules are helpful, if only for this reason), and have introduced API breaks in the past (removal of Schnorr signatures, various changes in convention, etc).

I would rather keep the submodule (for now) because each commit in this repo links to the version it should be built against, so in 6 months time even if upstream changes master building should still work.

Once it's released there should be official packages in debian and ubuntu, so we can just aim to support those instead of every commit.

@jjz
Copy link
Author

jjz commented Jul 5, 2017

submodule is used to compile and install , without having to depend in cgo 。
it's released there should be official packages in debian and ubuntu
is anybody doing this ?

@afk11
Copy link
Contributor

afk11 commented Jul 5, 2017

There is an unofficial package in debian stretch (https://packages.debian.org/stretch/libsecp256k1-0), but the developers haven't formally released the code, and haven't signed his release. It's definitely 'use at your own risk' until there are gitian builds by the authors & others.

As for when the library maintainers will make a formal release, I am not sure. There has been an open issue about it since 2015, but it hasn't stopped people from using it anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants