Skip to content

Fix build warnings

Fix build warnings #84

Triggered via push January 22, 2025 04:42
Status Success
Total duration 6m 16s
Artifacts 4

build-test.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 62 warnings
build-desktop-mac
Process completed with exit code 3.
build-desktop-mac
Process completed with exit code 3.
build-desktop-mac
Process completed with exit code 3.
build-desktop-mac
Process completed with exit code 3.
build-desktop-linux
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build-desktop-linux: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
build-desktop-linux: BTCPayApp.Core/Wallet/LightningNodeService.cs#L174
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-linux: BTCPayApp.Core/Wallet/LightningNodeService.cs#L184
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L66
Possible null reference return.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L84
Possible null reference return.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L175
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_httpClient' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_network' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_node' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-linux: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_channelManager' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-mac: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
build-desktop-mac: BTCPayApp.Core/Wallet/LightningNodeService.cs#L174
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-mac: BTCPayApp.Core/Wallet/LightningNodeService.cs#L184
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L66
Possible null reference return.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L84
Possible null reference return.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L175
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_httpClient' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_network' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_node' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build-desktop-mac: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L236
Non-nullable field '_channelManager' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
test-desktop
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-desktop: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
test-desktop: BTCPayApp.Core/Wallet/LightningNodeService.cs#L174
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
test-desktop: BTCPayApp.Core/Wallet/LightningNodeService.cs#L184
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
test-desktop: BTCPayApp.Core/Data/TriggerRecord.cs#L5
Non-nullable property 'name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/TriggerRecord.cs#L6
Non-nullable property 'sql' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L66
Possible null reference return.
test-desktop: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L84
Possible null reference return.
test-desktop: BTCPayApp.Core/Data/Setting.cs#L9
Non-nullable property 'Value' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/LSP/JIT/VoltageFlow2Jit.cs#L175
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
test-desktop: BTCPayApp.Core/Data/Channel.cs#L29
Non-nullable property 'Channel' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/DatabaseConfigProvider.cs#L134
Possible null reference assignment.
test-desktop: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
test-desktop: BTCPayApp.Core/Data/TriggerRecord.cs#L5
Non-nullable property 'name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/TriggerRecord.cs#L6
Non-nullable property 'sql' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/Setting.cs#L9
Non-nullable property 'Value' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/Channel.cs#L29
Non-nullable property 'Channel' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/Channel.cs#L9
Non-nullable property 'Data' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/Data/Channel.cs#L10
Non-nullable property 'Aliases' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/LSP/JIT/FlowFeeRequest.cs#L9
Non-nullable property 'PubKey' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
test-desktop: BTCPayApp.Core/JsonConverters/DateTimeToUnixTimeConverter.cs#L17
Possible null reference argument for parameter 's' in 'long long.Parse(string s)'.
build-desktop-win: BTCPayApp.Core/DatabaseConfigProvider.cs#L134
Possible null reference assignment.
build-desktop-win: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
build-desktop-win: BTCPayApp.Core/Data/TriggerRecord.cs#L5
Non-nullable property 'name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/TriggerRecord.cs#L6
Non-nullable property 'sql' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/Channel.cs#L9
Non-nullable property 'Data' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/Channel.cs#L10
Non-nullable property 'Aliases' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/Channel.cs#L29
Non-nullable property 'Channel' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/Setting.cs#L9
Non-nullable property 'Value' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build-desktop-win: BTCPayApp.Core/Data/AppDbContext.cs#L34
Dereference of a possibly null reference.
build-desktop-win: BTCPayApp.Core/Data/AppDbContext.cs#L39
Dereference of a possibly null reference.
build-android: BTCPayApp.Core/Wallet/OnChainWalletManager.cs#L143
Possible null reference argument for parameter 'source' in 'bool Enumerable.Contains<string?>(IEnumerable<string?> source, string? value)'.
build-android: BTCPayApp.Core/Wallet/LightningNodeService.cs#L174
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-android: BTCPayApp.Core/Wallet/LightningNodeService.cs#L184
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build-android: BTCPayApp.Core/DatabaseConfigProvider.cs#L134
Possible null reference assignment.
build-android: BTCPayApp.Core/Helpers/ChannelExtensions.cs#L41
Converting null literal or possible null value to non-nullable type.
build-android: BTCPayApp.Core/Helpers/ChannelExtensions.cs#L50
Possible null reference argument for parameter 'network' in 'OutputDescriptor OutputDescriptor.Parse(string desc, Network network, bool requireCheckSum = false, ISigningRepository? repo = null)'.
build-android: BTCPayApp.Core/Helpers/ChannelExtensions.cs#L59
Cannot convert null literal to non-nullable reference type.
build-android: BTCPayApp.Core/Helpers/ChannelExtensions.cs#L63
Nullability of reference types in value of type '(BitcoinExtPubKey Extkey, RootedKeyPath?)' doesn't match target type '(BitcoinExtPubKey, RootedKeyPath)'.
build-android: BTCPayApp.Core/Helpers/ObservableConcurrentDictionary.cs#L280
Possible null reference assignment.
build-android: BTCPayApp.Core/Helpers/ConfigHelpers.cs#L17
Possible null reference return.

Artifacts

Produced during runtime
Name Size
android build
52.9 MB
linux build
77.7 MB
mac-dmg
73.4 MB
windows build
117 MB