Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translucent badge option #64

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add translucent badge option #64

merged 1 commit into from
Jun 26, 2024

Conversation

dennisreimann
Copy link
Member

In addition to the standard badges (first row), this adds a translucent version with background opacity (second row):

  • Text: Color Variant 700
  • Background: Full background with an opacity of 50%

grafik

@dstrukt
Copy link
Member

dstrukt commented Apr 24, 2024

Assuming we don't switch any of these colors depending on the mode...

Screen Shot 2024-04-24 at 12 57 26 PM

Which makes me wonder if we should kill the Light/Dark/Secondary variants, but if we did this, it begs the question if the the more translucent variations aren't suitable, and i'll need to do a 100% opacity of the lighter value .. might explore this quickly.

Changes:

  • Full background should have an opacity of 25%

  • Primary text color should be our 500 variant

  • Success text color should be our 500 variant

  • Danger text color should be our 500 variant

  • Warning text color should be our 600 variant

  • Secondary text color should be our 800 variant

  • Info text color should be our 500 variant

  • Dark text color should be our pure "white"

  • Dark background color should be our 500 variant

I think about covers it.

@dstrukt
Copy link
Member

dstrukt commented Apr 25, 2024

Alternatively, if we go with the 200 variant background-color, full opacity. I don't like it as much, but this could work.
A)
Screen Shot 2024-04-24 at 8 58 06 PM

Playing around with colors a bit more...
B)
Screen Shot 2024-04-24 at 9 04 57 PM

and full circle...with the full colors...for reference
Screen Shot 2024-04-24 at 9 11 10 PM

@dennisreimann
Copy link
Member Author

Updated it and removed the Light/Dark/Secondary variants.

Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll adjust if anything causes issues!

@dennisreimann dennisreimann merged commit a7a6827 into master Jun 26, 2024
1 check passed
@dennisreimann dennisreimann deleted the badge-translucent branch June 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants