Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly check Docker version #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ docker_update() {
fi

docker_version="$(docker version -f "{{ .Server.Version }}")"
# Can't run with docker-ce before 20.10.10... check against version 21 instead, easier to compare
if [ "21" \> "$docker_version" ] && [[ "20.10.10" != "$docker_version" ]]; then
# Can't run with docker-ce before 20.10.10
if dpkg --compare-versions "$docker_version" '<<' 20.10.10; then
echo "Updating docker, old version can't run some images (https://docs.linuxserver.io/FAQ/#jammy)"
echo \
"deb [arch="$(dpkg --print-architecture)" signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu \
Expand Down