Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dropbox Backup Client #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Dropbox Backup Client #4

wants to merge 6 commits into from

Conversation

JeffVandrewJr
Copy link

@JeffVandrewJr JeffVandrewJr mentioned this pull request Mar 26, 2019
Merged
@NicolasDorier
Copy link
Member

Can you put it with a version number and rename it as the other docker files (only for amd64) ? I use a tagging mechanism to build this.

NicolasDorier
NicolasDorier reviewed Mar 26, 2019
View reviewed changes
btcpay-dropbox/Dockerfile Outdated
COPY . /btcpay-dropbox

RUN pip install dropbox

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mssing ENV DROPBOX_TOKEN so DROPBOX_TOKEN get implicitely passed from the host to the container.

NicolasDorier
NicolasDorier reviewed Mar 26, 2019
View reviewed changes
btcpay-dropbox/1.0.1/linuxamd64.Dockerfile Outdated

COPY . /btcpay-dropbox

RUN pip install dropbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this before the copy so that changing the dropbox-script will not invalidate the previous docker layers when you rebuild the image.

@JeffVandrewJr
Copy link
Author

JeffVandrewJr commented Mar 26, 2019 •
edited
Loading

@NicolasDorier

  1. My apologies for not following the format of the other directories previously. I have fixed that.

  2. I have moved the pip install earlier in the Dockerfile as you suggest.

  3. Regarding ENV DROPBOX_TOKEN, I will address over at Add Automated Backup btcpayserver-docker#117. I've got a new backup.sh and will post about everything over there in a few minutes.

@Kukks Kukks force-pushed the master branch 2 times, most recently from 4af0f9a to 596dd76 Compare October 10, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasDorier NicolasDorier NicolasDorier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffVandrewJr @NicolasDorier