Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: add flag to write execution traces #2223

Merged

Conversation

kcalvinalvin
Copy link
Collaborator

Execution traces are part of the go runtime tooling and is useful to check what is slowing down the ibd. For example, a slow ibd because of slow block downloads from peers won't show up on cpu profiling but will on a trace.

Also execution tracing has gotten a lot better with go 1.22

@coveralls
Copy link

coveralls commented Aug 6, 2024

Pull Request Test Coverage Report for Build 11929861494

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 57.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btcd.go 0 9 0.0%
Totals Coverage Status
Change from base Build 11704113837: 0.03%
Covered Lines: 29896
Relevant Lines: 52210

💛 - Coveralls

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 🎉

config.go Outdated Show resolved Hide resolved
Execution traces are part of the go runtime tooling and is useful to
check what is slowing down the ibd.  For example, a slow ibd because of
slow block downloads from peers won't show up on cpu profiling but will
on a trace.
@kcalvinalvin kcalvinalvin force-pushed the 2024-08-06-execution-trace-flag branch from 713536e to 10ef9cc Compare November 20, 2024 08:50
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐝

@Roasbeef Roasbeef merged commit e9d95ee into btcsuite:master Nov 20, 2024
3 checks passed
@dstadulis
Copy link

Exciting new functionality 🤓 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants