netsync: ignore tx invs when we're not current #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12080515585Details
💛 - Coveralls |
During ibd sometimes we may ban our sync peers because we're attempting to fetch some txs that may already been confirmed and don't exist in the mempool anymore. Since we shouldn't be fetching txs anyways when we're not current, this commit changes the handleInvMsg logic to ignore tx invs if the node is not caught up to the tip. Fixes btcsuite#1984
kcalvinalvin
force-pushed
the
2024-10-29-dont-accept-txs-when-were-not-current
branch
from
2d25bae to
fedf34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During ibd sometimes we may ban our sync peers because we're attempting to fetch some txs that may already been confirmed and don't exist in the mempool anymore.
Since we shouldn't be fetching txs anyways when we're not current, this commit changes the handleInvMsg logic to ignore tx invs if the node is not caught up to the tip.
Fixes #1984