Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testnet4 support #2275

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add testnet4 support #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a132d3
chaincfg, wire: add initial api for testnet4
joshuasing Jul 9, 2024
5ddb967
Use proper merkleroot and reverse hash of genesis block
marcopeereboom Nov 6, 2024
60c1447
Start adding TestNet4 bits thorughout the code
marcopeereboom Nov 6, 2024
1b83020
Sundry
marcopeereboom Nov 6, 2024
99a1144
Fixup deployments
marcopeereboom Nov 6, 2024
d8dacf1
For now disable checkpoints and panic on consensus errors so that the…
marcopeereboom Nov 7, 2024
2cbe0a0
A few more bits
marcopeereboom Nov 7, 2024
3b0fc23
Sprinkle more TestNet4
marcopeereboom Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions blockchain/chain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,8 +1317,8 @@ func TestIsAncestor(t *testing.T) {
// randomSelect selects random amount of random elements from a slice and returns a
// new slice. The selected elements are removed.
func randomSelect(input []*testhelper.SpendableOut) (
[]*testhelper.SpendableOut, []*testhelper.SpendableOut) {

[]*testhelper.SpendableOut, []*testhelper.SpendableOut,
) {
selected := []*testhelper.SpendableOut{}

// Select random elements from the input slice
Expand All @@ -1343,8 +1343,8 @@ func randomSelect(input []*testhelper.SpendableOut) (
// the hashes of the newly generated blocks.
func addBlocks(count int, chain *BlockChain, prevBlock *btcutil.Block,
allSpendableOutputs []*testhelper.SpendableOut) (
[]*chainhash.Hash, [][]*testhelper.SpendableOut, error) {

[]*chainhash.Hash, [][]*testhelper.SpendableOut, error,
) {
blockHashes := make([]*chainhash.Hash, 0, count)
spendablesOuts := make([][]*testhelper.SpendableOut, 0, count)

Expand Down
6 changes: 3 additions & 3 deletions blockchain/difficulty.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,7 @@ func findPrevTestNetDifficulty(startNode HeaderCtx, c ChainCtx) uint32 {
// the exported version uses the current best chain as the previous HeaderCtx
// while this function accepts any block node. This function accepts a ChainCtx
// parameter that gives the necessary difficulty context variables.
func calcNextRequiredDifficulty(lastNode HeaderCtx, newBlockTime time.Time,
c ChainCtx) (uint32, error) {

func calcNextRequiredDifficulty(lastNode HeaderCtx, newBlockTime time.Time, c ChainCtx) (uint32, error) {
// Emulate the same behavior as Bitcoin Core that for regtest there is
// no difficulty retargeting.
if c.ChainParams().PoWNoRetargeting {
Expand All @@ -154,6 +152,8 @@ func calcNextRequiredDifficulty(lastNode HeaderCtx, newBlockTime time.Time,
// required difficulty once too much time has elapsed without
// mining a block.
if c.ChainParams().ReduceMinDifficulty {
// XXX TestNet4 issue is here somewhere!

// Return minimum difficulty when more than the desired
// amount of time has elapsed without mining a block.
reductionTime := int64(c.ChainParams().MinDiffReductionTime /
Expand Down
9 changes: 9 additions & 0 deletions blockchain/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/btcsuite/btcd/btcutil"
"github.com/btcsuite/btcd/chaincfg/chainhash"
"github.com/btcsuite/btcd/database"
"github.com/btcsuite/btcd/wire"
)

// BehaviorFlags is a bitmask defining tweaks to the normal behavior when
Expand All @@ -29,6 +30,9 @@ const (
// not be performed.
BFNoPoWCheck

// BFEnforceBIP94 testnet4 shit
BFEnforceBIP94

// BFNone is a convenience value to specifically indicate no flags.
BFNone BehaviorFlags = 0
)
Expand Down Expand Up @@ -144,6 +148,11 @@ func (b *BlockChain) ProcessBlock(block *btcutil.Block, flags BehaviorFlags) (bo
defer b.chainLock.Unlock()

fastAdd := flags&BFFastAdd == BFFastAdd
if b.chainParams.Net == wire.TestNet4 {
if flags&BFEnforceBIP94 != BFEnforceBIP94 {
panic("BFEnforceBIP94 flag not set")
}
}

blockHash := block.Hash()
log.Tracef("Processing block %v", blockHash)
Expand Down
26 changes: 11 additions & 15 deletions blockchain/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,7 @@ func IsCoinBase(tx *btcutil.Tx) bool {
// SequenceLockActive determines if a transaction's sequence locks have been
// met, meaning that all the inputs of a given transaction have reached a
// height or time sufficient for their relative lock-time maturity.
func SequenceLockActive(sequenceLock *SequenceLock, blockHeight int32,
medianTimePast time.Time) bool {

func SequenceLockActive(sequenceLock *SequenceLock, blockHeight int32, medianTimePast time.Time) bool {
// If either the seconds, or height relative-lock time has not yet
// reached, then the transaction is not yet mature according to its
// sequence locks.
Expand Down Expand Up @@ -344,8 +342,8 @@ func checkProofOfWork(header *wire.BlockHeader, powLimit *big.Int, flags Behavio
// CheckProofOfWork ensures the block header bits which indicate the target
// difficulty is in min/max range and that the block hash is less than the
// target difficulty as claimed.
func CheckProofOfWork(block *btcutil.Block, powLimit *big.Int) error {
return checkProofOfWork(&block.MsgBlock().Header, powLimit, BFNone)
func CheckProofOfWork(block *btcutil.Block, powLimit *big.Int, flags BehaviorFlags) error {
return checkProofOfWork(&block.MsgBlock().Header, powLimit, flags)
}

// CountSigOps returns the number of signature operations for all transaction
Expand Down Expand Up @@ -432,9 +430,7 @@ func CountP2SHSigOps(tx *btcutil.Tx, isCoinBaseTx bool, utxoView *UtxoViewpoint)
//
// The flags do not modify the behavior of this function directly, however they
// are needed to pass along to checkProofOfWork.
func CheckBlockHeaderSanity(header *wire.BlockHeader, powLimit *big.Int,
timeSource MedianTimeSource, flags BehaviorFlags) error {

func CheckBlockHeaderSanity(header *wire.BlockHeader, powLimit *big.Int, timeSource MedianTimeSource, flags BehaviorFlags) error {
// Ensure the proof of work bits in the block header is in min/max range
// and the block hash is less than the target value described by the
// bits.
Expand All @@ -454,6 +450,10 @@ func CheckBlockHeaderSanity(header *wire.BlockHeader, powLimit *big.Int,
return ruleError(ErrInvalidTime, str)
}

if flags&BFEnforceBIP94 == BFEnforceBIP94 {
// log.Error("not checking BFEnforceBIP94!")
}

// Ensure the block time is not too far in the future.
maxTimestamp := timeSource.AdjustedTime().Add(time.Second *
MaxTimeOffsetSeconds)
Expand Down Expand Up @@ -681,9 +681,7 @@ func compareScript(height int32, script []byte) error {
// This function MUST be called with the chain state lock held (for writes).
// NOTE: Ignore the above lock requirement if this function is not passed a
// *Blockchain instance as the ChainCtx argument.
func CheckBlockHeaderContext(header *wire.BlockHeader, prevNode HeaderCtx,
flags BehaviorFlags, c ChainCtx, skipCheckpoint bool) error {

func CheckBlockHeaderContext(header *wire.BlockHeader, prevNode HeaderCtx, flags BehaviorFlags, c ChainCtx, skipCheckpoint bool) error {
fastAdd := flags&BFFastAdd == BFFastAdd
if !fastAdd {
// Ensure the difficulty specified in the block header matches
Expand All @@ -699,7 +697,7 @@ func CheckBlockHeaderContext(header *wire.BlockHeader, prevNode HeaderCtx,
if blockDifficulty != expectedDifficulty {
str := "block difficulty of %d is not the expected value of %d"
str = fmt.Sprintf(str, blockDifficulty, expectedDifficulty)
return ruleError(ErrUnexpectedDifficulty, str)
// return ruleError(ErrUnexpectedDifficulty, str)
}

// Ensure the timestamp for the block header is after the
Expand Down Expand Up @@ -1372,9 +1370,7 @@ func (b *BlockChain) MaxRetargetTimespan() int64 {
// checkpoints.
//
// NOTE: Part of the ChainCtx interface.
func (b *BlockChain) VerifyCheckpoint(height int32,
hash *chainhash.Hash) bool {

func (b *BlockChain) VerifyCheckpoint(height int32, hash *chainhash.Hash) bool {
return b.verifyCheckpoint(height, hash)
}

Expand Down
6 changes: 2 additions & 4 deletions btcd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ const (
blockDbNamePrefix = "blocks"
)

var (
cfg *config
)
var cfg *config

// winServiceMain is only invoked on Windows. It detects when btcd is running
// as a service and reacts accordingly.
Expand Down Expand Up @@ -387,7 +385,7 @@ func loadBlockDB() (database.DB, error) {
}

// Create the db if it does not exist.
err = os.MkdirAll(cfg.DataDir, 0700)
err = os.MkdirAll(cfg.DataDir, 0o700)
if err != nil {
return nil, err
}
Expand Down
74 changes: 74 additions & 0 deletions chaincfg/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"time"

"github.com/btcsuite/btcd/chaincfg/chainhash"

"github.com/btcsuite/btcd/wire"
)

Expand Down Expand Up @@ -143,6 +144,79 @@ var testNet3GenesisBlock = wire.MsgBlock{
Transactions: []*wire.MsgTx{&genesisCoinbaseTx},
}

// testNet4GenesisCoinbaseTx is the coinbase transaction for the genesis block
// for the test network (version 4).
var testNet4GenesisCoinbaseTx = wire.MsgTx{
Version: 1,
TxIn: []*wire.TxIn{
{
PreviousOutPoint: wire.OutPoint{
Hash: chainhash.Hash{},
Index: 0xffffffff,
},
SignatureScript: []byte{
0x04, 0xff, 0xff, 0x00, 0x1d, 0x01, 0x04, 0x4c, // |.......L|
0x4c, 0x30, 0x33, 0x2f, 0x4d, 0x61, 0x79, 0x2f, // |L03/May/|
0x32, 0x30, 0x32, 0x34, 0x20, 0x30, 0x30, 0x30, // |2024 000|
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, // |00000000|
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, // |00000000|
0x30, 0x31, 0x65, 0x62, 0x64, 0x35, 0x38, 0x63, // |01ebd58c|
0x32, 0x34, 0x34, 0x39, 0x37, 0x30, 0x62, 0x33, // |244970b3|
0x61, 0x61, 0x39, 0x64, 0x37, 0x38, 0x33, 0x62, // |aa9d783b|
0x62, 0x30, 0x30, 0x31, 0x30, 0x31, 0x31, 0x66, // |b001011f|
0x62, 0x65, 0x38, 0x65, 0x61, 0x38, 0x65, 0x39, // |be8ea8e9|
0x38, 0x65, 0x30, 0x30, 0x65, // |8e00e|
},
Sequence: 0xffffffff,
},
},
TxOut: []*wire.TxOut{
{
Value: 0x12a05f200,
PkScript: []byte{
0x21, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // |!.......|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // |........|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // |........|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // |........|
0x00, 0x00, 0xac, // |...|
},
},
},
LockTime: 0,
}

// testNet4GenesisHash is the hash of the first block in the block chain for the
// test network (version 4).
var testNet4GenesisHash = chainhash.Hash([chainhash.HashSize]byte{
0x43, 0xf0, 0x8b, 0xda, 0xb0, 0x50, 0xe3, 0x5b,
0x56, 0x7c, 0x86, 0x4b, 0x91, 0xf4, 0x7f, 0x50,
0xae, 0x72, 0x5a, 0xe2, 0xde, 0x53, 0xbc, 0xfb,
0xba, 0xf2, 0x84, 0xda, 0x00, 0x00, 0x00, 0x00,
})

// testNet4GenesisMerkleRoot is the hash of the first transaction in the genesis
// block for the test network (version 4).
var testNet4GenesisMerkleRoot = chainhash.Hash([chainhash.HashSize]byte{
0x4e, 0x7b, 0x2b, 0x91, 0x28, 0xfe, 0x02, 0x91,
0xdb, 0x06, 0x93, 0xaf, 0x2a, 0xe4, 0x18, 0xb7,
0x67, 0xe6, 0x57, 0xcd, 0x40, 0x7e, 0x80, 0xcb,
0x14, 0x34, 0x22, 0x1e, 0xae, 0xa7, 0xa0, 0x7a,
})

// testNet4GenesisBlock defines the genesis block of the block chain which
// serves as the public transaction ledger for the test network (version 4).
var testNet4GenesisBlock = wire.MsgBlock{
Header: wire.BlockHeader{
Version: 1,
PrevBlock: chainhash.Hash{}, // 0000000000000000000000000000000000000000000000000000000000000000
MerkleRoot: testNet4GenesisMerkleRoot, // 7aa0a7ae1e223414cb807e40cd57e667b718e42aaf9306db9102fe28912b7b4e
Timestamp: time.Unix(1714777860, 0), // 2024-05-03 23:11:00 +0000 UTC
Bits: 0x1d00ffff, // 486604799 [00000000ffff0000000000000000000000000000000000000000000000000000]
Nonce: 0x17780cbb, // 393743547
},
Transactions: []*wire.MsgTx{&testNet4GenesisCoinbaseTx},
}

// simNetGenesisHash is the hash of the first block in the block chain for the
// simulation test network.
var simNetGenesisHash = chainhash.Hash([chainhash.HashSize]byte{ // Make go vet happy.
Expand Down
89 changes: 89 additions & 0 deletions chaincfg/genesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,31 @@ func TestTestNet3GenesisBlock(t *testing.T) {
}
}

func TestTestNet4GenesisBlock(t *testing.T) {
// Encode the genesis block to raw bytes.
var buf bytes.Buffer
err := TestNet4Params.GenesisBlock.Serialize(&buf)
if err != nil {
t.Fatalf("TestTestNet4GenesisBlock: %v", err)
}

// Ensure the encoded block matches the expected bytes.
if !bytes.Equal(buf.Bytes(), testNet4GenesisBlockBytes) {
t.Fatalf("TestTestNet4GenesisBlock: Genesis block does not "+
"appear valid - got %v, want %v",
spew.Sdump(buf.Bytes()),
spew.Sdump(testNet4GenesisBlockBytes))
}

// Check hash of the block against expected hash.
hash := TestNet4Params.GenesisBlock.BlockHash()
if !TestNet4Params.GenesisHash.IsEqual(&hash) {
t.Fatalf("TestTestNet4GenesisBlock: Genesis block hash does "+
"not appear valid - got %v, want %v", spew.Sdump(hash),
spew.Sdump(TestNet4Params.GenesisHash))
}
}

// TestSimNetGenesisBlock tests the genesis block of the simulation test network
// for validity by checking the encoded bytes and hashes.
func TestSimNetGenesisBlock(t *testing.T) {
Expand Down Expand Up @@ -268,6 +293,70 @@ var testNet3GenesisBlockBytes = []byte{
0xac, 0x00, 0x00, 0x00, 0x00, /* |.....| */
}

// testNet4GenesisBlockBytes are the wire encoded bytes for the genesis block of
// the test network (version 4) as of protocol version 70002.
var _testNet4GenesisBlockBytes = []byte{
0x01, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0xff,
0xff, 0x55, 0x04, 0xff, 0xff, 0x00, 0x1d, 0x01,
0x04, 0x4c, 0x4c, 0x30, 0x33, 0x2f, 0x4d, 0x61,
0x79, 0x2f, 0x32, 0x30, 0x32, 0x34, 0x20, 0x30,
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30,
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30,
0x30, 0x30, 0x30, 0x31, 0x65, 0x62, 0x64, 0x35,
0x38, 0x63, 0x32, 0x34, 0x34, 0x39, 0x37, 0x30,
0x62, 0x33, 0x61, 0x61, 0x39, 0x64, 0x37, 0x38,
0x33, 0x62, 0x62, 0x30, 0x30, 0x31, 0x30, 0x31,
0x31, 0x66, 0x62, 0x65, 0x38, 0x65, 0x61, 0x38,
0x65, 0x39, 0x38, 0x65, 0x30, 0x30, 0x65, 0xff,
0xff, 0xff, 0xff, 0x01, 0x00, 0xf2, 0x05, 0x2a,
0x01, 0x00, 0x00, 0x00, 0x23, 0x21, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xac,
0x00, 0x00, 0x00, 0x00,
}

var testNet4GenesisBlockBytes = []byte{
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x4e, 0x7b, 0x2b, 0x91, /* |....N{+.| */
0x28, 0xfe, 0x02, 0x91, 0xdb, 0x06, 0x93, 0xaf, /* |(.......| */
0x2a, 0xe4, 0x18, 0xb7, 0x67, 0xe6, 0x57, 0xcd, /* |*...g.W.| */
0x40, 0x7e, 0x80, 0xcb, 0x14, 0x34, 0x22, 0x1e, /* |@~...4".| */
0xae, 0xa7, 0xa0, 0x7a, 0x04, 0x6f, 0x35, 0x66, /* |...z.o5f| */
0xff, 0xff, 0x00, 0x1d, 0xbb, 0x0c, 0x78, 0x17, /* |......x.| */
0x01, 0x01, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, /* |........| */
0xff, 0xff, 0x55, 0x04, 0xff, 0xff, 0x00, 0x1d, /* |..U.....| */
0x01, 0x04, 0x4c, 0x4c, 0x30, 0x33, 0x2f, 0x4d, /* |..LL03/M| */
0x61, 0x79, 0x2f, 0x32, 0x30, 0x32, 0x34, 0x20, /* |ay/2024 | */
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, /* |00000000| */
0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, /* |00000000| */
0x30, 0x30, 0x30, 0x30, 0x31, 0x65, 0x62, 0x64, /* |00001ebd| */
0x35, 0x38, 0x63, 0x32, 0x34, 0x34, 0x39, 0x37, /* |58c24497| */
0x30, 0x62, 0x33, 0x61, 0x61, 0x39, 0x64, 0x37, /* |0b3aa9d7| */
0x38, 0x33, 0x62, 0x62, 0x30, 0x30, 0x31, 0x30, /* |83bb0010| */
0x31, 0x31, 0x66, 0x62, 0x65, 0x38, 0x65, 0x61, /* |11fbe8ea| */
0x38, 0x65, 0x39, 0x38, 0x65, 0x30, 0x30, 0x65, /* |8e98e00e| */
0xff, 0xff, 0xff, 0xff, 0x01, 0x00, 0xf2, 0x05, /* |........| */
0x2a, 0x01, 0x00, 0x00, 0x00, 0x23, 0x21, 0x00, /* |*....#!.| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* |........| */
0xac, 0x00, 0x00, 0x00, 0x00, /* |..... | */
}

// simNetGenesisBlockBytes are the wire encoded bytes for the genesis block of
// the simulation test network as of protocol version 70002.
var simNetGenesisBlockBytes = []byte{
Expand Down
Loading
Loading