Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire, peer: fix broken ibd #2281

Merged

Conversation

kcalvinalvin
Copy link
Collaborator

IBD for new nodes were broken due to the version handshake failing between nodes that recognized wtxid based relays. Reverting the changes that were made so that the node is able to connect to those nodes.

fixes #2280

IBD for new nodes were broken due to the version handshake failing
between nodes that recognized wtxid based relays.  Reverting the changes
that were made so that the node is able to connect to those nodes.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12079870400

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 57.245%

Changes Missing Coverage Covered Lines Changed/Added Lines %
peer/peer.go 4 6 66.67%
Totals Coverage Status
Change from base Build 11941199528: 0.01%
Covered Lines: 29889
Relevant Lines: 52212

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Roasbeef
Copy link
Member

Roasbeef commented Dec 2, 2024

Nice, will test this out. Will also make an issue to finalize the wtxid relay feature as well.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧮

Confirmed the fix to the issue that exists in master.

@Roasbeef Roasbeef merged commit 25c804f into btcsuite:master Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect to peers for IBD on master
4 participants