chain+wallet: fix race over RescanProgress message
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Oct 16, 2023
chain/bitcoind_conn.go
Outdated
| for { | ||
| select { | ||
| // Timeout after 30s. | ||
| case <-time.After(30 * time.Second): |
There was a problem hiding this comment.
Should we extract this into a constant at least or even make it configurable?
There was a problem hiding this comment.
updated to make it a constant
Crypt-iQ
approved these changes
Oct 16, 2023
chain/bitcoind_conn.go
Outdated
| func getBlockHashDuringStartup( | ||
| client *rpcclient.Client) (*chainhash.Hash, error) { | ||
|
|
||
| errCode := "-28" |
There was a problem hiding this comment.
nit: extract to constant above?
There was a problem hiding this comment.
updated to make it a constant
yyforyongyu
force-pushed
the
fix-rescan-race
branch
from
8df9fb9 to
c594e4a
Compare
guggero
requested changes
Oct 17, 2023
yyforyongyu
force-pushed
the
fix-rescan-race
branch
from
c594e4a to
062a90f
Compare
We sometimes see this error in test,
```
--- FAIL: TestBitcoindEvents (7.72s)
--- FAIL: TestBitcoindEvents/Events_via_RPC_Polling (1.00s)
bitcoind_events_test.go:480:
Error Trace: /home/runner/work/btcwallet/btcwallet/chain/bitcoind_events_test.go:480
/home/runner/work/btcwallet/btcwallet/chain/bitcoind_events_test.go:49
Error: Received unexpected error:
-28: Loading block index…
Test: TestBitcoindEvents/Events_via_RPC_Polling
FAIL
```
which can also happen in real life if `bitcoind` is still loading
blocks. This commit adds a retry logic to wait for `bitcoind` to finish
its startup.
yyforyongyu
force-pushed
the
fix-rescan-race
branch
from
062a90f to
148ac23
Compare
Crypt-iQ
approved these changes
Oct 17, 2023
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain+wallet: fix race over `RescanProgress` message
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain+wallet: fix race over `RescanProgress` message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race found in
lndside re multiple goroutines accessing theRescanProgress, details in this PR.It also fixes the case where
bitcoindis still loading blocks, causing theNewBitcoindConnto return an error.