chain: Match for error code instead of text. #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Oct 27, 2023
The error needs to be less verbose to catch more cases where bitcoind does not find the transaction in its mempool.
ziggie1984
force-pushed
the
small-err-match-fix
branch
from
2bfdb87
to
c64eb08
Compare
guggero
approved these changes
Oct 27, 2023
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain: Match for error code instead of text.
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain: Match for error code instead of text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #892.
The return value of bitcoind did not change, bitcoind will return a different error if the
txindexis not set (e.g. pruned nodes) so we check for the error code now instead of the specific text and include a direct reference of the bitcoind code.