chain: add TestMempoolAccept to chain interface
#899
Conversation
yyforyongyu
force-pushed
the
add-testmempool
branch
from
7312742
to
36e41df
Compare
wallet/wallet.go
Outdated
| @@ -4131,7 +4131,7 @@ func MapBroadcastBackendError(err error) error { | |||
| // | |||
| // https://github.com/bitcoin/bitcoin/blob/9bf5768dd628b3a7c30dd42b5ed477a92c4d3540/src/node/transaction.cpp#L49 | |||
| // https://github.com/bitcoin/bitcoin/blob/0.20/src/validation.cpp#L642 | |||
| case match(err, "missing inputs") || | |||
| case match(err, "missing-inputs") || | |||
There was a problem hiding this comment.
Wondering what we can do in the future to catch stuff like this...
Ofc it's the case that string error matching is fragile to being with, wish we had some concrete error codes here.
There was a problem hiding this comment.
Or should we be looking at one of these sources instead?
There was a problem hiding this comment.
Also fwiw, this gives a 404 now:
https://github.com/bitcoin/bitcoin/blob/0.20/src/validation.cpp#L642
There was a problem hiding this comment.
These two are my primary source when comparing RPC errors, as I'm not sure how bitcoind converts them internally, so I can only rely on the end results from its rpc responses,
- https://github.com/bitcoin/bitcoin/blob/master/test/functional/data/invalid_txs.py
- https://github.com/bitcoin/bitcoin/blob/master/test/functional/mempool_accept.py
Also updated the link, and added a new method to properly handle error matching. Meanwhile plan to work on something in btcd/btcjson - this way we can have a single place to track the bitcoind errors and handles the matching then turning them into defined error types.
yyforyongyu
force-pushed
the
add-testmempool
branch
2 times, most recently
from
8d0af32
to
956cc29
Compare
|
cc: @ellemouton for review |
yyforyongyu
force-pushed
the
add-testmempool
branch
from
956cc29
to
38c00dc
Compare
TestMempoolAcceptis now added to chain interface so it can be accessed via chain io inlnd.