chain: add mempool lookup for outpoints #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
add-mempool-lookup
branch
2 times, most recently
from
472d3ac
to
9344055
Compare
Roasbeef
reviewed
Feb 26, 2024
yyforyongyu
force-pushed
the
add-mempool-lookup
branch
from
e82ccac
to
79348ac
Compare
yyforyongyu
force-pushed
the
add-mempool-lookup
branch
from
79348ac
to
fc0d8ca
Compare
Chinwendu20
reviewed
Mar 1, 2024
guggero
approved these changes
Mar 1, 2024
chain/btcd.go
Outdated
| // disconnected. | ||
| func NewRPCClientWithConfig(cfg *RPCClientConfig) (*RPCClient, error) { | ||
| // Make sure the config is supplied. | ||
| if cfg == nil { |
There was a problem hiding this comment.
nit: the way Go works, this check could be in the validate() method.
There was a problem hiding this comment.
Won't that cause a nil deference? Or you mean before initializing the client we do a validation on config in lnd?
There was a problem hiding this comment.
No, the thing is, in Go you can call a method on a struct, even if the struct itself is nil.
So you can do:
// validate checks the required config options are set.
func (r *RPCClientConfig) validate() error {
// Make sure the config is supplied.
if r == nil {
return errors.New("missing rpc config")
}
// Make sure retry attempts is positive.
if r.ReconnectAttempts < 0 {
return errors.New("reconnectAttempts must be positive")
}
...
There was a problem hiding this comment.
Ohhh cool, TILed, thanks!
There was a problem hiding this comment.
Yeh at time a check on the nil pointer can actually be useful.
|
Can be rebased with the |
This commit adds a new method to look up mempool spent for a given outpoint.
yyforyongyu
force-pushed
the
add-mempool-lookup
branch
from
fc0d8ca
to
cdfd988
Compare
This commit adds a new method to init the RPC client. Unlike the `NewRPCClient`, it now takes a config to allow users specifying notification handlers. In the future, `NewRPCClient` should be replaced by this method. For now we implement it this way so other callsites relying on this method can stay out of being affected.
yyforyongyu
force-pushed
the
add-mempool-lookup
branch
from
cdfd988
to
524b1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
LookupInputMempoolSpendto directly check whether a given input has been spent or not in the mempool.