Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain+wallet: make use of the new errors from rpcclient #918

Merged
merged 2 commits into from
Mar 18, 2024
Merged

chain+wallet: make use of the new errors from rpcclient #918

merged 2 commits into from
Mar 18, 2024

Conversation

yyforyongyu
Copy link
Collaborator

This PR removes the string matching and makes use of the newly defined errors inside rpcclient.

@yyforyongyu yyforyongyu force-pushed the handle-error-matching branch from ed1095d to faee38a Compare March 14, 2024 21:17
@yyforyongyu yyforyongyu mentioned this pull request Mar 14, 2024
Merged
@yyforyongyu yyforyongyu force-pushed the handle-error-matching branch from faee38a to e6d686f Compare March 15, 2024 16:57
ziggie1984
ziggie1984 approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the cleanup makes definitely sense to put the error mapping into the btcd package 🙏

wallet/wallet.go Show resolved Hide resolved
guggero
guggero approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM pending existing comments (and dependent PR).

@yyforyongyu yyforyongyu force-pushed the handle-error-matching branch from e6d686f to 4b53048 Compare March 18, 2024 15:15
@guggero
Copy link
Collaborator

guggero commented Mar 18, 2024

Can be updated with final version of btcd.

@yyforyongyu yyforyongyu force-pushed the handle-error-matching branch from 4b53048 to e777139 Compare March 18, 2024 15:31
@guggero guggero merged commit 9a7dd24 into btcsuite:master Mar 18, 2024
3 checks passed
@yyforyongyu yyforyongyu deleted the handle-error-matching branch March 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziggie1984 ziggie1984 ziggie1984 approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyforyongyu @guggero @ziggie1984