Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Templates should use React Components w/ full lifecycle #3

Open
sankho opened this issue Jun 30, 2016 · 1 comment · May be fixed by #6
Open

Popup Templates should use React Components w/ full lifecycle #3

sankho opened this issue Jun 30, 2016 · 1 comment · May be fixed by #6

Comments

@sankho
Copy link
Contributor

sankho commented Jun 30, 2016

Currently you can only pass static markup to the popup tempaltes for bubbles / hovering over countries, arcs, etc.

You can use ReactDOMServer.renderToString to just get markup but then you're missing out on the component lifecycle methods e.g. componentDidMount, state and prop changes, etc.

@btmills This is the next thing I wanna work on for my project, can get started once the other updates etc are merged in. Might involve overriding datamap's native method for this.

@btmills
Copy link
Owner

btmills commented Jul 1, 2016

This would be great! The static markup is such a kludge when everything else is React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants