extends datamaps JS class to override updatePopup method #6
Conversation
|
💯 This is clever, I like it! Feel free to go ahead and port the examples over. 💥 |
|
@btmills hey dude - totally cool if this is not OK but I'm using this in production for a project I'm wrapping up. Having some troubles (of course) getting my forked version to work w/ our production build tool, even w/ NPM scopes... I can make a separate issue for the examples and get em done this weekend - but for the time being thing this can get merged in, up'd and npm published? Would be a huge help but understandable if not. |
|
@btmills ok sorry for the late night freakout - figured a workaround. Back to making examples in this PR! |
|
@sankho if it helps, I could publish this as an alpha under the reasoning that alphas are all about trying out new features, even if they're not quite ready to ship yet |
|
Hey @sankho, just checking in - do you plan on finishing this up? |
@btmills closes #3
Tested this using my own local project. Can add examples later on but wanted to do a first pass at a code review to make sure teh approach jives with how you're thinking