Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hangs from loadCommands #154

Closed
wants to merge 1 commit into from
Closed

Fix hangs from loadCommands #154

wants to merge 1 commit into from

Conversation

thewilloftheshadow
Copy link
Member

@thewilloftheshadow thewilloftheshadow commented Sep 24, 2024 •
edited
Loading

Fixes #91

This should fix several of the issues I was seeing with the loadCommands function

For more details, open the Copilot Workspace session.

@thewilloftheshadow thewilloftheshadow requested a review from a team as a code owner September 24, 2024 17:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 510eb3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the p:nodejs The node.js package label Sep 24, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 24, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon@154

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon-nodejs@154

pnpm add https://pkg.pr.new/buape/carbon/create-carbon@154

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon-request@154

commit: 510eb3f

@thewilloftheshadow
Fix hangs from loadCommands
510eb3f 
Fixes #91

This should fix several of the issues I was seeing with the loadCommands function

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/buape/carbon/issues/91?shareId=XXXX-XXXX-XXXX-XXXX).
@thewilloftheshadow thewilloftheshadow force-pushed the thewilloftheshadow/fix-loadCommands-hang branch from 0769e79 to 510eb3f Compare September 24, 2024 19:58
@apteryxxyz
Copy link
Member

Changeset? Tho I assume the next release will be 0.6.0 in which case the nodejs package will be removed anyway

@thewilloftheshadow
Copy link
Member Author

Oh true this will be fixed by nuke anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p:nodejs The node.js package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix hangs from loadCommands
2 participants
@thewilloftheshadow @apteryxxyz