Fixed a bug in the selective context where the update was recalculate…

…d for every listener, instead of propagating the new master value.
buchananwill · Apr 9, 2024 · 0d16358 · 0d16358
1 parent af1b557
commit 0d16358
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/app/playground/arcChart.tsx b/app/playground/arcChart.tsx
@@ -46,7 +46,7 @@ export default function ArcChart({ data }: { data: number[][] }) {
             BASE_HSL[HUE_OPTIONS[chord.target.index % HUE_OPTIONS.length].id]
               .cssHSLA;
           const endColor =
-            BASE_HSL[HUE_OPTIONS[chord.source.index % HUE_OPTIONS.length].id]
+            BASE_HSL[HUE_OPTIONS[chord.target.index % HUE_OPTIONS.length].id]
               .cssHSLA;
           return (
             <linearGradient id={id} x1="0%" y1="0%" x2="100%" y2="0%" key={id}>

diff --git a/app/selective-context/components/base/selective-context-manager.tsx b/app/selective-context/components/base/selective-context-manager.tsx
@@ -60,7 +60,7 @@ export function useSelectiveContextManager<T>(
     if (currentElement !== newValue) {
       try {
         Object.values(listeners).forEach((l) => {
-          l(update);
+          l(newValue);
         });
       } catch (e) {
         console.error(e);

diff --git a/app/selective-context/components/global/selective-context-creator-global.ts b/app/selective-context/components/global/selective-context-creator-global.ts
@@ -1,4 +1,4 @@
 'use client';
 import { createSelectiveContext } from '../base/generic-selective-context-creator';
 
-export const SelectContextGlobal = createSelectiveContext<any>();
+export const SelectiveContextGlobal = createSelectiveContext<any>();
diff --git a/app/selective-context/components/global/selective-context-manager-global.tsx b/app/selective-context/components/global/selective-context-manager-global.tsx
@@ -1,7 +1,7 @@
 'use client';
 import { PropsWithChildren } from 'react';
 import GenericSelectiveContextManager from '../base/generic-selective-context-manager';
-import { SelectContextGlobal } from './selective-context-creator-global';
+import { SelectiveContextGlobal } from './selective-context-creator-global';
 import {
   useSelectiveContextController,
   UseSelectiveContextParams
@@ -13,7 +13,7 @@ export default function SelectiveContextManagerGlobal({
   children
 }: PropsWithChildren) {
   return (
-    <GenericSelectiveContextManager {...SelectContextGlobal}>
+    <GenericSelectiveContextManager {...SelectiveContextGlobal}>
       {children}
     </GenericSelectiveContextManager>
   );
@@ -28,9 +28,9 @@ export function useSelectiveContextAnyController<T>({
     contextKey,
     listenerKey,
     initialValue,
-    SelectContextGlobal.listenerRefContext,
-    SelectContextGlobal.latestValueRefContext,
-    SelectContextGlobal.dispatchContext
+    SelectiveContextGlobal.listenerRefContext,
+    SelectiveContextGlobal.latestValueRefContext,
+    SelectiveContextGlobal.dispatchContext
   );
 }
 export function useSelectiveContextAnyDispatch<T>({
@@ -42,9 +42,9 @@ export function useSelectiveContextAnyDispatch<T>({
     contextKey,
     listenerKey,
     initialValue,
-    SelectContextGlobal.listenerRefContext,
-    SelectContextGlobal.latestValueRefContext,
-    SelectContextGlobal.dispatchContext
+    SelectiveContextGlobal.listenerRefContext,
+    SelectiveContextGlobal.latestValueRefContext,
+    SelectiveContextGlobal.dispatchContext
   );
 }
 
@@ -57,7 +57,7 @@ export function useSelectiveContextGlobalListener<T>({
     contextKey,
     listenerKey,
     initialValue,
-    SelectContextGlobal.listenerRefContext,
-    SelectContextGlobal.latestValueRefContext
+    SelectiveContextGlobal.listenerRefContext,
+    SelectiveContextGlobal.latestValueRefContext
   );
 }