Feature/payment provider gateway #636

LucianTuriacArnia · 2022-11-18T15:03:06Z

No description provided.

serpentscode · 2022-11-23T16:00:29Z

Gateway/Request/GiftcardsDataBuilder.php

+            $this->getOrder()->getStore()
+        );
+
+        $availableCards = $this->getPayment()->getAdditionalInformation('giftcard_method') ?? $availableCards . ',ideal';


Not sure if we need to display iDeal in giftcards list.

app/code/Buckaroo/Magento2/Model/Method/Giftcards.php:209 was added for this ticket https://buckaroonl.atlassian.net/browse/BP-185 by Sergey Saranchuk

serpentscode · 2022-11-23T16:00:54Z

Gateway/Request/Recipient/AbstractRecipientDataBuilder.php

+        return 'B2C';
+    }
+
+    protected function getGender(): string


Maybe we should add extra gender values here according to BP-1933.

I change these files:
app/code/Buckaroo/Magento2/Gateway/Request/PayPerEmailDataBuilder.php:37
app/code/Buckaroo/Magento2/Gateway/Request/Recipient/BillinkDataBuilder.php:56

serpentscode · 2022-11-23T16:01:10Z

Gateway/Request/Recipient/AfterpayOldDataBuilder.php

+    {
+        $data = [
+            'title' => $this->getFirstname(),
+            'gender' => $this->getGender(),


Gender is no longer required according to BP-1933.

serpentscode · 2022-11-23T16:01:46Z

Gateway/Request/Recipient/KlarnaDataBuilder.php

+    {
+        return [
+            'category' => $this->getCategory(),
+            'gender' => $this->getGender(),


If we add the extra values to the parent getGender method, we should add a new one here to contain only male/female values.

serpentscode · 2022-11-23T16:02:19Z

Gateway/Request/SepaDirectDebitDataBuilder.php

+        $customerAccountName = $paymentInfo->getAdditionalInformation('customer_account_name');
+
+        $data = [
+            'iban' => $customerIban,


Maybe we should add collectdate / mandateDate parameters

Thanks, in develop branch we don't add it, but I will check if the old version send it somehow.

serpentscode · 2022-11-23T16:02:52Z

Gateway/Request/TransferOrderDataBuilder.php

+    {
+        parent::initialize($buildSubject);
+        return [
+            'dateDue' => $this->transferConfig->getDueDateFormated($this->getOrder()->getStore()),


email, country, customer missing?

Are added by another builders

serpentscode · 2022-11-23T16:03:13Z

Gateway/Response/PayLinkHandler.php

+        if (!empty($paylink)) {
+            $this->messageManager->addSuccess(
+                __(
+                    'You PayLink <a href="%1">%1</a>',


Fix typo here to 'Your'

"You Bad" :))
I copied from this app/code/Buckaroo/Magento2/Controller/Adminhtml/PayLink/Index.php:147

serpentscode · 2022-11-23T16:05:20Z

Model/ConfigProvider/Predefined.php

+    /**
+     * {@inheritdoc}
+     */
+    public function getWsdlTestWeb($store = null)


I think we should remove this class and references since we don't use SOAP anymore.

"You Good", I will remove it

serpentscode

Buckaroo SDK is not present in composer.json, needs to be added.
~~BuckarooSDK doesn't work with Magento 2.4.3 (monolog conflict).~~
~~Fix for addLog function, doesn't work with Magento 2.4.3 .~~
Not sure if we still need Console/Command/PushSend.php.
Move updateShippingAddressCommonMappingV2 method from AbstractAddressBuilder to MyParcelAddressHandler (it's used only in this class).
Implement SDK's credentials checker method instead of current solution from Controller/CredentialChecker/Index.php->testJson(..).
I don't think we need a certificate to be uploaded anymore. Maybe we should remove this.

strajeru · 2023-01-04T07:47:14Z

Block/Adminhtml/Sales/Totals.php

@@ -151,10 +152,9 @@ private function getTotalsExceptCode($totals, $code)
    private function isCreditmemoTotalSelected($creditTotals, $saleTotal)
    {
        foreach ($creditTotals as $creditTotal) {
-            if (
-                isset($creditTotal['code']) && $creditTotal['code'] === $saleTotal['code']
+            if (    isset($creditTotal['code']) && $creditTotal['code'] === $saleTotal['code']


some unnecessary spaces inside the parentheses

strajeru · 2023-01-04T07:50:08Z

Api/PaypalExpressOrderCreateInterface.php

-    string $cart_id = null
-  );
+    public function execute(
+        string $paypal_order_id,


variable name should be camelCase

strajeru · 2023-01-04T07:56:09Z

Controller/Adminhtml/Giftcard/NewAction.php

+        \Magento\Backend\App\Action\Context               $context,
+        \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
+    ) {
+        $this->resultForwardFactory = $resultForwardFactory;


you don't need the resultForwardFactory dependency.
if this class extends \Magento\Backend\App\Action (and it does) you can create a forward response with

$this->resultFactory->create(\Magento\Framework\Controller\ResultFactory::TYPE_FORWARD)

$resultFactory is already added as a dependency in a parent class Magento\Framework\App\Action\AbstractAction

strajeru · 2023-01-04T08:00:12Z

Controller/Adminhtml/Giftcard/Delete.php

@@ -22,6 +23,11 @@

 class Delete extends \Buckaroo\Magento2\Controller\Adminhtml\Giftcard\Index


Controller action should implement a specific interface depending on the methods that are allowed for this action.

\Magento\Framework\App\Action\HttpGetActionInterface - for GET requests

\Magento\Framework\App\Action\HttpPostActionInterface - for POST requests

....
This prevents destructive actions (like delete for example) to be executed on GET requests.

strajeru · 2023-01-04T08:00:47Z

Controller/Adminhtml/Giftcard/NewAction.php

@@ -20,10 +21,34 @@

 namespace Buckaroo\Magento2\Controller\Adminhtml\Giftcard;

-class NewAction extends \Buckaroo\Magento2\Controller\Adminhtml\Giftcard\Index
+class NewAction extends \Magento\Backend\App\Action


Same as above, should implement an action interface (use Magento\Framework\App\Action\HttpGetActionInterface in this case)

Helper/Data.php

strajeru · 2023-01-04T09:30:49Z

Helper/PaymentGroupTransaction.php

@@ -157,7 +174,7 @@ public function getGroupTransactionAmount($order_id)

    public function getGroupTransactionOriginalTransactionKey($order_id)
    {
-        if($order_id === null) {
+        if ($order_id === null) {


var name should be camelCase

strajeru · 2023-01-04T09:34:02Z

Helper/PaymentGroupTransaction.php

-
-        $this->order       = $order;
+        $this->dateTime = $dateTime;
+        $this->order = $order;


most likele $ordershould not be a dependency of the calss. A repository should be used to retrieve the order. Not even sure if it is used in the class at all

strajeru · 2023-01-04T09:35:35Z

Logging/DbHandler.php

+        \Magento\Customer\Model\Session $customerSession
+    ) {
+        $this->logFactory = $logFactory;
+        $this->checkoutSession  = $checkoutSession;


checkoutSession, session and customer session are not used in the class. There is no need for the dependencies here.

strajeru · 2023-01-04T10:16:16Z

Setup/Patch/Data/SetupModuleDataPatch.php

    /**
     * @param ModuleDataSetupInterface $setup
     *
     * @return $this
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
     */


this is just a remarkt, not sure if it;s worth fixing at this point. module should not add columns to the order related tables. all module related data should reside in a separate table with a FK to the orders (quote, items, ...) tables. If this module gets installed on a database with 100k+ orders for example the install script will take a lot of time and might even crash. Doing this properly at this point will require a lot of time and a lot of code changes. not sure if it;s worth changing, but it's sure worth investigating.

…ultibanco-Magento-2-refactor BP-2981

…n-canceled-in-magento' into BP-2748-giftcard-grouptransaction-canceled-in-magento

…o feature/payment_provider_gateway # Conflicts: # Controller/Applepay/Add.php # Controller/Applepay/Common.php # Controller/Applepay/GetShippingMethods.php # Controller/Applepay/SaveOrder.php # Controller/Applepay/UpdateShippingMethods.php # Model/Method/AbstractMethod.php # Model/Method/Capayable.php # Service/Applepay/Add.php

…d-tinka-magento-2-refactor BP-3502 Remove payment method: Tinka

…ency-refactor BP-3451 - Missing dependency - refactor

…b2b-mode-subtext-and-tooltip-information BP-3391 improve payperemail b2b mode subtext and tooltip information

…o feature/payment_provider_gateway # Conflicts: # Model/Config/Source/PaymentMethods/AfterExpiry.php # Model/Config/Source/PaymentMethods/PayLink.php # Model/Config/Source/PaymentMethods/PayPerEmail.php # Model/ConfigProvider/Method/Voucher.php # etc/adminhtml/system/payment_methods.xml # etc/adminhtml/system/payment_methods/voucher.xml # etc/config.xml # etc/di.xml # etc/frontend/di.xml # view/frontend/layout/checkout_index_index.xml # view/frontend/web/js/view/payment/buckaroo-payments.js # view/frontend/web/js/view/payment/method-renderer/giftcards.js

…/buckaroo-it/Magento2 into BP-3510-partial-refunds-with-approvals-refactor

…g-of-payment-methods-on-the-configuration-settings BP-3533 incorrect positioning of payment methods on the configuration settings

…yment is not saved

…-approvals-refactor BP-3510 partial refunds with approvals refactor

…g-provider Fix Creditcard config provider

…data-refactor BP-3540 creditcard company data missing

…/buckaroo-it/Magento2 into sonarqube-refactor-fixes # Conflicts: # Gateway/Request/Articles/ArticlesHandler/AfterpayHandler.php # Gateway/Validator/IssuerValidator.php # Gateway/Validator/ResponseCodeSDKValidator.php # Model/ConfigProvider/Method/Applepay.php # Model/Push/DefaultProcessor.php # Model/Service/CreateInvoice.php

…/buckaroo-it/Magento2 into BP-3413-sync-with-develop

…cards BP-3543 fix issues with giftcards

Sonarqube refactor fixes

BP-3413 sync with develop

LucianTuriacArnia · 2024-04-24T15:48:53Z

We created another branch: "refactor"

LucianTuriacArnia marked this pull request as draft November 18, 2022 15:03

Buckaroo-Rens requested a review from serpentscode November 18, 2022 15:26

serpentscode reviewed Nov 23, 2022

View reviewed changes

strajeru reviewed Jan 4, 2023

View reviewed changes

Buckaroo-Rens requested review from florinel-chis and harli91 February 2, 2023 15:07

harli91 previously approved these changes Mar 24, 2023

View reviewed changes

LucianTuriacArnia dismissed harli91’s stale review via 7d09134 April 12, 2023 07:26

harli91 removed the request for review from florinel-chis April 26, 2023 06:22

Buckaroo-Rene previously approved these changes Jun 20, 2023

View reviewed changes

LucianTuriacArnia dismissed Buckaroo-Rene’s stale review via 154ce29 June 20, 2023 12:15

Buckaroo-Rene previously approved these changes Aug 17, 2023

View reviewed changes

LucianTuriacArnia dismissed Buckaroo-Rene’s stale review via 0596b9d August 24, 2023 12:49

Rinor12010 and others added 9 commits November 10, 2023 16:02

Apply logo changes from media repository

894ec6f

BP-3115 - When the order is finished another product is created on order

89431a0

Apply logo changes from media repository

ff1ab29

Merge pull request #847 from buckaroo-it/BP-2981-Add-payment-method-M…

c0d78e7

…ultibanco-Magento-2-refactor BP-2981

Add afterpay2 from develop

338df1c

Merge remote-tracking branch 'origin/BP-2748-giftcard-grouptransactio…

0180be0

…n-canceled-in-magento' into BP-2748-giftcard-grouptransaction-canceled-in-magento

BP-2981-Add-Payment-Method-MBWay

85c89df

Fix PHP Stan and PHP MD

68798ec

LucianTuriacArnia and others added 25 commits April 12, 2024 11:41

Merge pull request #959 from buckaroo-it/BP-3502-remove-payment-metho…

c499528

…d-tinka-magento-2-refactor BP-3502 Remove payment method: Tinka

Merge pull request #960 from buckaroo-it/BP-3451-check-missing-depend…

4536142

…ency-refactor BP-3451 - Missing dependency - refactor

Merge pull request #949 from buckaroo-it/BP-3391-improve-payperemail-…

0c4cb0b

…b2b-mode-subtext-and-tooltip-information BP-3391 improve payperemail b2b mode subtext and tooltip information

BP-3510 - partial refunds

0556133

BP-3510 - partial refunds

c883ff2

Merge branch 'feature/payment_provider_gateway' of https://github.com…

e16a24c

…/buckaroo-it/Magento2 into BP-3510-partial-refunds-with-approvals-refactor

BP-3533 - incorrect positioning of payment methods in admin.

9f204ab

Merge pull request #962 from buckaroo-it/BP-3533-incorrect-positionin…

ee83246

…g-of-payment-methods-on-the-configuration-settings BP-3533 incorrect positioning of payment methods on the configuration settings

BP-3510 - fix partial refunds - rollback before else the order and pa…

6c18fe5

…yment is not saved

BP-3510 - fix partial refunds - rollback before else the order and pa…

0d807ab

…yment is not saved

BP-3510 - fix partial refunds - rollback before else the order and pa…

d541db3

…yment is not saved

Fix PHPMD

1ee6af0

Fix PHPMD

adfc1e5

Merge pull request #963 from buckaroo-it/BP-3510-partial-refunds-with…

3680271

…-approvals-refactor BP-3510 partial refunds with approvals refactor

Fix Creditcard config provider

c0510e3

Merge pull request #965 from buckaroo-it/hotfix/fix-creditcards-confi…

f4225fa

…g-provider Fix Creditcard config provider

Fix Creditcards - the name of the additional parameter was changed in js

9ccf3b9

Merge pull request #966 from buckaroo-it/BP-3540-send-the-creditcard-…

44b1d79

…data-refactor BP-3540 creditcard company data missing

Merge branch 'feature/payment_provider_gateway' of https://github.com…

eeea7d2

…/buckaroo-it/Magento2 into BP-3413-sync-with-develop

BP-3543-fix-issues-with-giftcards-redirect

ca6638e

Merge pull request #971 from buckaroo-it/BP-3543-fix-issues-with-gift…

336b4df

…cards BP-3543 fix issues with giftcards

Merge pull request #970 from buckaroo-it/sonarqube-refactor-fixes

9442dad

Sonarqube refactor fixes

Merge pull request #948 from buckaroo-it/BP-3413-sync-with-develop

64f6278

BP-3413 sync with develop

LucianTuriacArnia closed this Apr 24, 2024

LucianTuriacArnia deleted the feature/payment_provider_gateway branch April 24, 2024 15:49

LucianTuriacArnia restored the feature/payment_provider_gateway branch April 24, 2024 15:50

LucianTuriacArnia deleted the feature/payment_provider_gateway branch April 24, 2024 15:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/payment provider gateway #636

Feature/payment provider gateway #636

LucianTuriacArnia commented Nov 18, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode Nov 23, 2022

serpentscode Nov 23, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode Nov 23, 2022

LucianTuriacArnia Nov 25, 2022

serpentscode left a comment

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

strajeru Jan 4, 2023

LucianTuriacArnia commented Apr 24, 2024

		@@ -22,6 +23,11 @@

		class Delete extends \Buckaroo\Magento2\Controller\Adminhtml\Giftcard\Index

Feature/payment provider gateway #636

Feature/payment provider gateway #636

Conversation

LucianTuriacArnia commented Nov 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serpentscode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucianTuriacArnia commented Apr 24, 2024