Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP-2621 Rename 'Creditcards' into 'Credit and debit card' #746

Merged
merged 3 commits into from
Jul 7, 2023
Merged

BP-2621 Rename 'Creditcards' into 'Credit and debit card' #746

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cc0aae
BP-2621 Rename 'Creditcards' into 'Credit and debit card'
Jun 29, 2023
cb6fdf1
remove additonal dot
Jun 29, 2023
2665e74
add translations
Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Helper/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@ public function getPaymentMethodsList()
['value' => 'applepay', 'label' => __('Apple Pay')],
['value' => 'billink', 'label' => __('Billink')],
['value' => 'capayablein3', 'label' => __('In3')],
['value' => 'creditcard', 'label' => __('Creditcards')],
['value' => 'creditcards', 'label' => __('Creditcards (Client sided)')],
['value' => 'creditcard', 'label' => __('Credit and debit cards')],
['value' => 'creditcards', 'label' => __('Credit and debit cards (Client sided)')],
['value' => 'emandate', 'label' => __('Digital Debit Authorization')],
['value' => 'eps', 'label' => __('EPS')],
['value' => 'giftcards', 'label' => __('Giftcards')],
Expand Down
14 changes: 7 additions & 7 deletions etc/adminhtml/system/payment_methods/creditcard.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
*/
-->
<include xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_include.xsd">
<!-- Creditcards Payment method group -->
<!-- Credit and debit card Payment method group -->
<group id="buckaroo_magento2_creditcard" translate="label" type="text" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Creditcards</label>
<label>Credit and debit cards</label>
<frontend_model>Buckaroo\Magento2\Block\Config\Form\Field\Fieldset</frontend_model>

<field id="active" translate="label comment" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Enable Creditcards</label>
<label>Enable credit and debit cards</label>
<comment><![CDATA[Enable or disable this payment method.]]></comment>
<source_model>Buckaroo\Magento2\Model\Config\Source\Enablemode</source_model>
<config_path>payment/buckaroo_magento2_creditcard/active</config_path>
Expand Down Expand Up @@ -66,16 +66,16 @@
</field>

<field id="allowed_creditcards" translate="label comment" type="multiselect" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Allowed Creditcards</label>
<comment><![CDATA[Select payment method specific Creditcards.]]></comment>
<label>Allowed credit and debit cards</label>
<comment><![CDATA[Select payment method specific Credit and debit card.]]></comment>
<config_path>payment/buckaroo_magento2_creditcard/allowed_creditcards</config_path>
<source_model>Buckaroo\Magento2\Model\Config\Source\Creditcard</source_model>
</field>

<field id="sort_creditcards" translate="label comment" type="text" sortOrder="50" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Sort Creditcards</label>
<label>Sort credit and debit cards</label>
<frontend_model>Buckaroo\Magento2\Block\Adminhtml\Creditcard\Sort</frontend_model>
<comment><![CDATA[Select sort order Creditcards.]]></comment>
<comment><![CDATA[Select sort order on credit and debit card.]]></comment>
<config_path>payment/buckaroo_magento2_creditcard/sorted_creditcards</config_path>
</field>

Expand Down
10 changes: 5 additions & 5 deletions etc/adminhtml/system/payment_methods/creditcards.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
*/
-->
<include xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_include.xsd">
<!-- Creditcards Payment method group -->
<!-- Credit and debit card Payment method group -->
<group id="buckaroo_magento2_creditcards" translate="label" type="text" sortOrder="35" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Creditcards (Client sided)</label>
<label>Credit and debit cards (Client sided)</label>
<frontend_model>Buckaroo\Magento2\Block\Config\Form\Field\Fieldset</frontend_model>

<field id="active" translate="label comment tooltip" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Enable Creditcards (Client sided)</label>
<label>Enable credit and debit cards (Client sided)</label>
<comment><![CDATA[Enable or disable this payment method.]]></comment>
<source_model>Buckaroo\Magento2\Model\Config\Source\Enablemode</source_model>
<config_path>payment/buckaroo_magento2_creditcards/active</config_path>
Expand Down Expand Up @@ -69,8 +69,8 @@
</field>

<field id="allowed_creditcards" translate="label comment" type="multiselect" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Allowed Creditcards</label>
<comment><![CDATA[Select payment method specific Creditcards.]]></comment>
<label>Allowed credit and debit cards</label>
<comment><![CDATA[Select payment method specific Credit and debit card.]]></comment>
<config_path>payment/buckaroo_magento2_creditcards/allowed_creditcards</config_path>
<source_model>Buckaroo\Magento2\Model\Config\Source\Creditcard</source_model>
</field>
Expand Down
4 changes: 2 additions & 2 deletions etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
<active>0</active>
<model>Buckaroo\Magento2\Model\Method\Creditcard</model>
<order_status>pending</order_status>
<title>Buckaroo Creditcard and Debit Card</title>
<title>Buckaroo Creditcard and Debit Cards</title>
<allowspecific>0</allowspecific>
<sort_order>30</sort_order>
<order_email>1</order_email>
Expand All @@ -138,7 +138,7 @@
<active>0</active>
<model>Buckaroo\Magento2\Model\Method\Creditcards</model>
<order_status>pending</order_status>
<title>Buckaroo Creditcards</title>
<title>Buckaroo Creditcard and Debit Cards</title>
<sort_order>35</sort_order>
<order_email>1</order_email>
<payment_fee_label>Fee</payment_fee_label>
Expand Down
8 changes: 4 additions & 4 deletions i18n/de_DE.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"Display only for selected IPs","Nur für bestimmte IPs anzeigen"
"Show method only to Magento set IPs.","Nur für bestimmte in Magento festgelegte IPs anzeigen."
"Magento developer client restrictions.","Zeigen Sie diese Zahlungsmethode nur ausgewählten Magento-IPs an. Diese Option ist für Magento-Entwickler gedacht, wenn Sie eine bestimmte Zahlungsmethode testen möchten, ohne sie öffentlich zu zeigen."
"Creditcards","Kreditkarten"
"Enable Creditcards","Kreditkarten aktivieren"
"Allowed Creditcards","Akzeptierte Kreditkarten"
"Select payment method specific Creditcards","Wählen Sie bestimmte Kreditkarten für die Zahlungsmethode aus."
"Credit and debit cards","Kreditkarten"
"Enable credit and debit cards","Kreditkarten aktivieren"
"Allowed credit and debit cards","Akzeptierte Kreditkarten"
"Select payment method specific Credit and debit card.","Wählen Sie bestimmte Kreditkarten für die Zahlungsmethode aus."
"American Express Specific","American Express-spezifisch"
"Verify address","Adressvalidierung"
"Set true to verify the address at American Express. Set false to disable address verification","Kreuzen Sie 'Ja' an, um die Adresse mit American Express zu bestätigen. Auf 'no' setzen, um die Adressüberprüfung zu deaktivieren."
Expand Down
8 changes: 4 additions & 4 deletions i18n/es_ES.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"Display only for selected IPs","Mostrar solo para IP seleccionadas"
"Show method only to Magento set IPs.","Mostrar método de pago solo para IP establecidas por Magento."
"Magento developer client restrictions.","Esta opción es para desarrolladores, y se usa cuando se quiere probar un método de pago específico sin mostrarlo públicamente."
"Creditcards","Tarjetas de crédito"
"Enable Creditcards","Activar tarjetas de crédito"
"Allowed Creditcards","Tarjetas de crédito permitidas",
"Select payment method specific Creditcards","Seleccionar tarjetas de crédito específicas del método de pago"
"Credit and debit cards","Tarjetas de crédito"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buckaroo-Rene the translation should be also updated, ex: "Tarjetas de crédito y débito" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buckaroo-Rens

"Enable credit and debit cards","Activar tarjetas de crédito"
"Allowed credit and debit cards","Tarjetas de crédito permitidas",
"Select payment method specific Credit and debit card.","Seleccionar tarjetas de crédito específicas del método de pago"
"American Express Specific","Específico de American Express"
"Verify address","Comprobar dirección"
"Set true to verify the address at American Express. Set false to disable address verification","Elegir 'cierto' para comprobar la dirección en American Express. Elegir 'falso' para desactivar la comprobación de la dirección"
Expand Down
8 changes: 4 additions & 4 deletions i18n/fr_FR.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"Display only for selected IPs","Afficher uniquement pour les adresses IP sélectionnées"
"Show method only to Magento set IPs.","Afficher la méthode uniquement sur les adresses IP définies par Magento."
"Magento developer client restrictions.","N'affichez ce mode de paiement qu'aux IP Magento sélectionnées. Cette option est destinée aux développeurs lorsque vous souhaitez tester un mode de paiement spécifique sans le montrer publiquement."
"Creditcards","Cartes de crédit"
"Enable Creditcards","Activer les Cartes de crédit"
"Allowed Creditcards","Cartes de crédit autorisées"
"Select payment method specific Creditcards","Sélectionnez les cartes de crédit spécifiques au mode de paiement."
"Credit and debit cards","Cartes de crédit"
"Enable credit and debit cards","Activer les Cartes de crédit"
"Allowed credit and debit cards","Cartes de crédit autorisées"
"Select payment method specific Credit and debit card.","Sélectionnez les cartes de crédit spécifiques au mode de paiement."
"American Express Specific","Spécifique à American Express"
"Verify address","Vérifier l'adresse"
"Set true to verify the address at American Express. Set false to disable address verification","Définissez true pour vérifier l'adresse auprès d'American Express. Définissez false pour désactiver la vérification d'adresse."
Expand Down
8 changes: 4 additions & 4 deletions i18n/nl_BE.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"Display only for selected IPs","Toon alleen voor specifieke IP's"
"Show method only to Magento set IPs.","Toon alleen voor specifieke IP's ingesteld bij Magento."
"Magento developer client restrictions.","Toon deze betaalmethode alleen aan geselecteerde Magento IPs. Deze optie is voor ontwikkelaars wanneer je een specifieke betaalmethode wilt testen zonder dat deze publiekelijk wordt getoond."
"Creditcards","Creditcards"
"Enable Creditcards","Creditcards inschakelen"
"Allowed Creditcards","Geaccepteerde creditcards"
"Select payment method specific Creditcards","Selecteer specifieke creditcards voor de betaalmethode."
"Credit and debit cards","Credit and debit cards"
"Enable credit and debit cards","Creditcards inschakelen"
"Allowed credit and debit cards","Geaccepteerde creditcards"
"Select payment method specific credit and debit card","Selecteer specifieke creditcards voor de betaalmethode."
"American Express Specific","American Express Specifiek"
"Verify address","Adresvalidatie"
"Set true to verify the address at American Express. Set false to disable address verification","Zet op 'ja' om het adres bij American Express te veriferen. Zet op 'nee' om het adresverificatie uit te schakelen."
Expand Down
8 changes: 4 additions & 4 deletions i18n/nl_NL.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"Display only for selected IPs","Toon alleen voor specifieke IP's"
"Show method only to Magento set IPs.","Toon alleen voor specifieke IP's ingesteld bij Magento."
"Magento developer client restrictions.","Toon deze betaalmethode alleen aan geselecteerde Magento IPs. Deze optie is voor ontwikkelaars wanneer je een specifieke betaalmethode wilt testen zonder dat deze publiekelijk wordt getoond."
"Creditcards","Creditcards"
"Enable Creditcards","Creditcards inschakelen"
"Allowed Creditcards","Geaccepteerde creditcards"
"Select payment method specific Creditcards","Selecteer specifieke creditcards voor de betaalmethode."
"Credit and debit cards","Credit and debit cards"
"Enable credit and debit cards","Creditcards inschakelen"
"Allowed credit and debit cards","Geaccepteerde creditcards"
"Select payment method specific Credit and debit card.","Selecteer specifieke creditcards voor de betaalmethode."
"American Express Specific","American Express Specifiek"
"Verify address","Adresvalidatie"
"Set true to verify the address at American Express. Set false to disable address verification","Zet op 'ja' om het adres bij American Express te veriferen. Zet op 'nee' om het adresverificatie uit te schakelen."
Expand Down
Loading