BP-3353 Refactor SQL query for enhanced security #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced direct string concatenation with DbQuery class in the query. - Added input sanitization using pSQL to prevent SQL injection vulnerabilities. The update ensures that the query handling adheres to PrestaShop's best practices, enhancing both code maintainability and security. Also fixed Idin, after testing the new changes I saw that idin was not appearing at all in checkout
harli91
suggested changes
Jan 15, 2024
|
|
||
| $sql->select('buckaroo_idin'); | ||
| $sql->from('bk_product_idin'); | ||
| $sql->where('product_id = ' . pSQL($productId)); |
There was a problem hiding this comment.
why aren't you using prepared statements?
There was a problem hiding this comment.
you can use $sql->where('product_id = :product_id')->setParameter('product_id ', pSQL($productId));
There was a problem hiding this comment.
Method 'setParameter' not found in \DbQuery
There was a problem hiding this comment.
I dont see setParameter.
https://devdocs.prestashop-project.org/8/development/components/database/dbquery/
There was a problem hiding this comment.
sorry, saw this code https://github.com/buckaroo-it/PrestaShop/blob/develop/src/Repository/PaymentMethodRepository.php#L43-L44, but from what I see this uses the entity manager query builder not the \DbQuery class
ShuCh3n
approved these changes
Jan 15, 2024
Buckaroo-Rene
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update ensures that the query handling adheres to PrestaShop's best practices, enhancing both code maintainability and security.
Also fixed Idin, after testing the new changes I saw that idin was not appearing at all in checkout